Skip to content

build!: update node runtime to version 24 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 6 commits into from
Mar 12, 2026
Merged

build!: update node runtime to version 24 #567

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ed106e
build(Node.js): Upgrade Node.js runtime version.
desrosj Mar 12, 2026
7ac5af3
build: tsc against esnext
zimeg Mar 12, 2026
1965b26
ci: attempt updates of @types/node for 24.x
zimeg Mar 12, 2026
3c756ac
build: use minimum npm@11.3 to match node@24
zimeg Mar 12, 2026
8d63bbc
build: use minimum lts versions
zimeg Mar 12, 2026
8a347ee
chore: lockfile
zimeg Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ updates:
ignore:
- dependency-name: "@types/node"
versions:
- "21.x"
- "22.x"
- "23.x"
- "24.x"
- "25.x"
- package-ecosystem: "github-actions"
directory: "/"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
24
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ outputs:
ts:
description: "The timestamp of a Slack message or event in the response."
runs:
using: "node20"
using: "node24"
Copy link
Copy Markdown
Member

@zimeg zimeg Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 note: This is the change that's surfaced for actioneers using this step!

🔗 https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/#what-you-need-to-do

main: "dist/index.js"
8 changes: 4 additions & 4 deletions jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
"checkJs": true,
"esModuleInterop": true,
"lib": [
"ES2023"
"ESNext"
],
"module": "node16",
"moduleResolution": "node",
"module": "nodenext",
"moduleResolution": "nodenext",
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"target": "ES2022"
"target": "ESNext"
},
"exclude": [
"node_modules"
Expand Down
22 changes: 12 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"type": "module",
"scripts": {
"build": "ncc build src/index.js --license licenses.txt --source-map",
"check": "tsc --noemit --module es2022 --project ./jsconfig.json",
"dev": "act public --eventpath .github/resources/.actions/event.json --secret-file .github/resources/.env --platform ubuntu-latest=node:20-buster --container-architecture linux/amd64",
Copy link
Copy Markdown
Member

@zimeg zimeg Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

"check": "tsc --noemit --project ./jsconfig.json",
"dev": "act public --eventpath .github/resources/.actions/event.json --secret-file .github/resources/.env --platform ubuntu-latest=node:24 --container-architecture linux/amd64",
"lint:fix": "biome check --write",
"lint": "biome check",
"test": "node --test --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=test/coverage.txt test/*.spec.js",
Expand All @@ -29,8 +29,8 @@
"url": "https://github.com/slackapi/slack-github-action/issues"
},
"engines": {
"node": ">=20.0.0",
"npm": ">=10.2.0"
"node": ">=24.0.0",
"npm": ">=11.3.0"
Copy link
Copy Markdown
Contributor Author

@desrosj desrosj Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest using 24.11.0 and 11.6.1? This was the the version that transitioned 24.x to LTS and the version of npm bundled with it.

Copy link
Copy Markdown
Member

@zimeg zimeg Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desrosj TIL about these later moves to LTS! Thanks for sharing this 👾 ✨

We added this in 8d63bbc with findings that runner images support the latest LTS versions and I understand self-hosted runners act similar 🤖

Tool name Installation strategy
Node.js 3 latest LTS versions

🔗 https://github.com/actions/runner-images?tab=readme-ov-file#software-and-image-support

},
"homepage": "https://docs.slack.dev/tools/slack-github-action/",
"dependencies": {
Expand All @@ -50,7 +50,7 @@
"@types/flat": "^5.0.5",
"@types/js-yaml": "^4.0.9",
"@types/markup-js": "^1.5.0",
"@types/node": "^20.19.35",
"@types/node": "^24.12.0",
"@types/sinon": "^21.0.0",
"@vercel/ncc": "^0.38.4",
"sinon": "^21.0.1",
Expand Down
Loading