feat: add optional filepath argument to run command#417
feat: add optional filepath argument to run command#417zimeg wants to merge 1 commit intozimeg-fix-env-quotefrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## zimeg-fix-env-quote #417 +/- ##
=======================================================
- Coverage 68.62% 68.59% -0.04%
=======================================================
Files 218 218
Lines 18164 18177 +13
=======================================================
+ Hits 12465 12468 +3
- Misses 4539 4545 +6
- Partials 1160 1164 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
🌚 A few thoughts of these changes shared for kind reviewers!
| var appPath string | ||
| if len(args) > 0 { | ||
| appPath = args[0] | ||
| if _, err := clients.Fs.Stat(appPath); err != nil { | ||
| return slackerror.New(slackerror.ErrNotFound). | ||
| WithMessage("The app path %q could not be found", appPath). | ||
| WithRemediation("Check that the file exists and the path is correct") | ||
| } | ||
| } |
There was a problem hiding this comment.
| var appPath string | |
| if len(args) > 0 { | |
| appPath = args[0] | |
| if _, err := clients.Fs.Stat(appPath); err != nil { | |
| return slackerror.New(slackerror.ErrNotFound). | |
| WithMessage("The app path %q could not be found", appPath). | |
| WithRemediation("Check that the file exists and the path is correct") | |
| } | |
| } |
🪓 note: I'm curious of removing this in favor of leaving errors to the hook implementations. Removing this might let for strange argument parsing as perhaps:
$ slack run localhost
👾 ramble: For now it seems to make a better experience for the intended filepath arguments I think-
| Args: cobra.MaximumNArgs(1), | ||
| Example: style.ExampleCommandsf([]style.ExampleCommand{ | ||
| {Command: "platform run", Meaning: "Start a local development server"}, | ||
| {Command: "platform run --activity-level debug", Meaning: "Run a local development server with debug activity"}, |
There was a problem hiding this comment.
🗣️ note: IIRC this activity level flag isn't used often so we might encourage examples that outline another common use case?
| func NewRunCommand(clients *shared.ClientFactory) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "run", | ||
| Use: "run [app-path]", |
There was a problem hiding this comment.
📚 note: I'm not so excited about this placeholder but it's clear to me...
Changelog
Summary
This PR adds an optional filepath argument to the
runcommand.Preview
Current and continued behavior:
With a path argument provided:
When the file doesn't exist:
Reviewers
The following commands shows the optional argument of a filepath for the
runcommand:Requirements