test(charm): clean up and consolidate charm tests#390
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 65.47% 65.48%
=======================================
Files 218 218
Lines 18120 18120
=======================================
+ Hits 11864 11865 +1
- Misses 5161 5162 +1
+ Partials 1095 1093 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Removes redundant tests and consolidates scattered test functions into table-driven tests in the
style package.
Summary
Follow-up to #365 (
charm-lipgloss-migration). That PR added new charm/lipgloss tests alongside existing aurora tests, resulting in some redundancy and inconsistent test patterns. This PR cleans that up.Removed redundant tests:
TestEmojiEmpty— subset ofTestEmoji(empty-string case folded in)TestRender—render()is already exercised by all 16testStyleFunccallsTest_styleExampleLine— internal helper already covered byTest_ExampleTemplatef_CharmTestStyleFlags_CharmDisabled— folded intoTestStyleFlagsas a table caseConsolidated into table-tests:
TestGetKeyLengthZero/Matched/Long/First(4 funcs → 1)TestSectionfEmpty/Header/EmptyEmoji(3 funcs → 1)TestSectionSecondaryfEmpty/Plain/Format/Indent(4 funcs → 1)TestCommandfPrimary/Secondary(2 funcs → 1)Test steps
make test testdir=internal/style make lintRequirements