Skip to content

feat(charm): add lipgloss styling with Slack brand colors under charm experiment#365

Open
srtaalej wants to merge 9 commits intomainfrom
charm-lipgloss-migration
Open

feat(charm): add lipgloss styling with Slack brand colors under charm experiment#365
srtaalej wants to merge 9 commits intomainfrom
charm-lipgloss-migration

Conversation

@srtaalej
Copy link
Contributor

@srtaalej srtaalej commented Mar 6, 2026

Changelog

Adds lipgloss-based styling to all help output under the charm experiment flag, using a centralized Slack brand color palette shared across all CLI components, and migrates all direct Styler() usage to named style functions. 🦋

Summary

This PR introduces a centralized Slack brand color palette (colors.go) as the single source of truth for all styling across lipgloss, huh themes, and future bubbletea components

  • Adds lipgloss-based styling to all CLI output functions (behind the charm experiment flag), alongside existing aurora styling
  • Migrates all external Styler() call sites to use new style functions (Green(), Red(), Yellow(), Gray())
  • Consolidates all legacy aurora code into one clearly marked block for easy removal when the charm experiment is permanently enabled
Screenshot 2026-03-10 at 7 24 57 PM

Test steps

make test testdir=internal/style  # all tests pass (including new TestStyleFlags and TestStyleFlags_CharmDisabled)
make test testdir=cmd/help  # all tests pass
make build 
./bin/slack --help -e charm  # flags show yellow names + gray descriptions, alias arrow uses ❱
./bin/slack project --help -e charm  # subcommand flags also styled (inherited help func)
./bin/slack run --help -e charm  # custom run help also styled (uses PrintHelpTemplate)
./bin/slack --help (no experiment)  # flags unchanged (plain text), arrow stays >
# Verify on both light and dark terminal backgrounds if possible

Requirements

@srtaalej srtaalej added this to the Next Release milestone Mar 6, 2026
@srtaalej srtaalej self-assigned this Mar 6, 2026
@srtaalej srtaalej added experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.50%. Comparing base (2ae86a3) to head (29b218e).

Files with missing lines Patch % Lines
internal/pkg/platform/activity.go 33.33% 4 Missing ⚠️
cmd/upgrade/upgrade.go 0.00% 2 Missing ⚠️
internal/pkg/apps/install.go 0.00% 2 Missing ⚠️
cmd/manifest/validate.go 50.00% 1 Missing ⚠️
internal/iostreams/printer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   65.27%   65.50%   +0.23%     
==========================================
  Files         216      216              
  Lines       17994    18065      +71     
==========================================
+ Hits        11745    11833      +88     
+ Misses       5160     5136      -24     
- Partials     1089     1096       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej marked this pull request as ready for review March 10, 2026 17:48
@srtaalej srtaalej requested a review from a team as a code owner March 10, 2026 17:48
@srtaalej srtaalej marked this pull request as draft March 10, 2026 17:54
@srtaalej srtaalej marked this pull request as ready for review March 11, 2026 00:02
@mwbrooks mwbrooks added changelog Use on updates to be included in the release notes and removed changelog Use on updates to be included in the release notes labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants