You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
40c4caa0
fix: align restoreObject docs test with idempotent behavior (#2745) (Julia Miller)
restoreObject was made idempotent in #2737 — it no longer throws
for objects with no restorable methods. Updates the docs page
and its corresponding test to reflect this.
a68dac19
fix: throw a clear error when throwArg index equals the argument count (#2743) (spokodev)
fix: throw a clear error when throwArg index equals the argument count
spyCall.throwArg(pos) guarded with pos > this.args.length, so calling it
with pos equal to the number of recorded arguments slipped past the guard
and reached throw this.args[pos], throwing undefined instead of the
intended TypeError. A thrown undefined cannot be inspected as an Error and
is reported by test frameworks as no exception thrown.
Use >= to match ensureArgs in behavior.js and the sibling callArg helpers,
which already reject an out-of-range index with a clear error.
9ea504e3
feat: make sinon.restoreObject idempotent (#2737) (Ilia Choly)
Passing an object with no live fakes to restoreObject now restores
nothing instead of throwing, giving it symmetry with sinon.restore()
and sandbox.restore(). The strict "found no methods" check is retained
for spy(object) and stub(object), which now use a dedicated
walkObjectStrict export, while restoreObject uses the loose walkObject.
Passing a falsy value still throws.
755a40d7
fix: isolate callId counter per sandbox for parallel test support (Vishal Kumar Singh)
The global callId counter in proxy-invoke.js caused calledImmediatelyBefore
and calledImmediatelyAfter to fail when tests run in parallel with separate
sandboxes. Each sandbox now maintains its own callId counter, passed through
the spy/stub/fake creation chain via a context object.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.11%. Comparing base (f5e9a01) to head (6a3e343).
✅ All tests successful. No failed tests found.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filejavascriptPull requests that update Javascript code
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sinon and @types/sinon. These dependencies needed to be updated together.
Updates
sinonfrom 21.0.2 to 22.1.0Changelog
Sourced from sinon's changelog.
... (truncated)
Commits
ab289e922.1.0bb3b75achore: remove Jekyll steps from version hookbb38f25chore: run docs tests in preversion hookd36e921fix: let returns override returnsArg11db213ci: run docs tests on every PR (#2746)40c4caafix: align restoreObject docs test with idempotent behavior (#2745)5ccb7fdbuild(deps): bump the action-deps group with 4 updates (#2744)a68dac1fix: throw a clear error when throwArg index equals the argument count (#2743)9ea504efeat: make sinon.restoreObject idempotent (#2737)cf5d9e8fix: remove dead link and exclude code example URLs from link checkUpdates
@types/sinonfrom 17.0.4 to 22.0.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)