Skip to content

health: publish test results to code cov #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 4 commits into from
Mar 28, 2025
Merged

health: publish test results to code cov #1282

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10997f3
health: publish test results to code cov
WilliamBergamin Mar 28, 2025
af3f83e
Update config to upload all tests
WilliamBergamin Mar 28, 2025
2e8cc9c
Try to only use the files property
WilliamBergamin Mar 28, 2025
ab18733
just use the directory
WilliamBergamin Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 24 additions & 39 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,60 +35,45 @@ jobs:
pip install -r requirements/testing_without_asyncio.txt
- name: Run tests without aiohttp
run: |
pytest tests/slack_bolt/
pytest tests/scenario_tests/
pytest tests/slack_bolt/ --junitxml=reports/test_slack_bolt.xml
pytest tests/scenario_tests/ --junitxml=reports/test_scenario.xml
- name: Install adapter dependencies
run: |
pip install -r requirements/adapter.txt
pip install -r requirements/adapter_testing.txt
- name: Run tests for HTTP Mode adapters (AWS)
- name: Run tests for HTTP Mode adapters
run: |
pytest tests/adapter_tests/aws/
- name: Run tests for HTTP Mode adapters (Bottle)
run: |
pytest tests/adapter_tests/bottle/
- name: Run tests for HTTP Mode adapters (CherryPy)
run: |
pytest tests/adapter_tests/cherrypy/
- name: Run tests for HTTP Mode adapters (Django)
run: |
pytest tests/adapter_tests/django/
- name: Run tests for HTTP Mode adapters (Falcon)
run: |
pytest tests/adapter_tests/falcon/
- name: Run tests for HTTP Mode adapters (Flask)
run: |
pytest tests/adapter_tests/flask/
- name: Run tests for HTTP Mode adapters (Pyramid)
run: |
pytest tests/adapter_tests/pyramid/
- name: Run tests for HTTP Mode adapters (Starlette)
run: |
pytest tests/adapter_tests/starlette/
- name: Run tests for HTTP Mode adapters (Tornado)
run: |
pytest tests/adapter_tests/tornado/
- name: Run tests for HTTP Mode adapters (WSGI)
run: |
pytest tests/adapter_tests/wsgi/
pytest tests/adapter_tests/ \
--ignore=tests/adapter_tests/socket_mode/ \
--ignore=tests/adapter_tests/asgi/ \
--junitxml=reports/test_adapter.xml
Comment on lines +46 to +49
Copy link
Copy Markdown
Member

@zimeg zimeg Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 I'm a big fan of this change!

I noticed this now covers the google_cloud_functions adapter which I'm not sure was run in CI beforehand 👾

- name: Install async dependencies
run: |
pip install -r requirements/async.txt
- name: Run tests for HTTP Mode adapters (ASGI)
run: |
# Requires async test dependencies
pytest tests/adapter_tests/asgi/ --junitxml=reports/test_adapter_asgi.xml
- name: Run tests for Socket Mode adapters
run: |
# Requires async test dependencies
pytest tests/adapter_tests/socket_mode/
pytest tests/adapter_tests/socket_mode/ --junitxml=reports/test_adapter_socket_mode.xml
- name: Run tests for HTTP Mode adapters (asyncio-based libraries)
run: |
pytest tests/adapter_tests_async/
- name: Run tests for HTTP Mode adapters (ASGI)
run: |
# Requires async test dependencies
pytest tests/adapter_tests/asgi/
pytest tests/adapter_tests_async/ --junitxml=reports/test_adapter_async.xml
- name: Install all dependencies
run: |
pip install -r requirements/testing.txt
- name: Run asynchronous tests
run: |
pytest tests/slack_bolt_async/
pytest tests/scenario_tests_async/
pytest tests/slack_bolt_async/ --junitxml=reports/test_slack_bolt_async.xml
pytest tests/scenario_tests_async/ --junitxml=reports/test_scenario_async.xml
- name: Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/test-results-action@v1
with:
directory: ./reports/
files: test*.xml
Copy link
Copy Markdown
Member

@zimeg zimeg Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
files: test*.xml
files: ./**/test*.xml

https://github.com/slackapi/bolt-python/actions/runs/14134899037/job/39604145700#step:14:183

Right now this raises a warning in outputs 🔍

Some files were not found --- {"not_found_files": ["test*.xml"]}

I think a standalone directory option might be another option, and this isn't a blocker at all! Just wanting to share findings ✨

Copy link
Copy Markdown
Contributor Author

@WilliamBergamin WilliamBergamin Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a great catch 🥇 I totally missed that warning, I'll try testing a few things out

flags: ${{ matrix.python-version }}
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ venv/
.coverage
cov_*
coverage.xml
reports/

# due to using tox and pytest
.tox
Expand Down
Loading