Skip to content

docs: convert commonjs imports to esm in building an app guides#2736

Open
zimeg wants to merge 4 commits intomainfrom
zimeg-docs-quickstart-esm
Open

docs: convert commonjs imports to esm in building an app guides#2736
zimeg wants to merge 4 commits intomainfrom
zimeg-docs-quickstart-esm

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Dec 10, 2025

Summary

This PR updates the "Building an App" guides to recommend ESM imports following related changes to the sample app in slack-samples/bolt-js-getting-started-app#22.

Notes

Requirements

@zimeg zimeg self-assigned this Dec 10, 2025
@zimeg zimeg requested a review from a team as a code owner December 10, 2025 01:49
@zimeg zimeg added docs M-T: Documentation work only semver:patch labels Dec 10, 2025
Copy link
Copy Markdown
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾 One note for the amazing reviewers but I am open to others!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ note: This page is moved to match the English translations above so the fallback Quickstart guide appears as expected!

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (968e48b) to head (c26e2d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2736   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          44       44           
  Lines        7861     7861           
  Branches      699      699           
=======================================
  Hits         7420     7420           
  Misses        435      435           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: c26e2d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants