Skip to content

feat: use set_suggested_prompts helper with agent_view #1549 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mwbrooks wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: use set_suggested_prompts helper with agent_view #1549 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions claude-agent-sdk/listeners/events/app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ async def handle_app_home_opened(
"""
try:
if event.get("tab") == "messages":
await client.assistant_threads_setSuggestedPrompts(
channel_id=event["channel"],
title="How can I help you today?",
await context.set_suggested_prompts(
prompts=SUGGESTED_PROMPTS,
title="How can I help you today?",
)
# TODO(agent-dm-messages-tab): handle app_context_changed once Bolt supports it
return
Expand Down
2 changes: 1 addition & 1 deletion claude-agent-sdk/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
slack-sdk==3.43.0
slack-bolt==1.29.0
../vendor/slack_bolt-1.29.0+pr1549.812f7c3-py2.py3-none-any.whl
slack-cli-hooks==0.3.0
claude-agent-sdk==0.2.114
aiohttp==3.14.1
Expand Down
10 changes: 5 additions & 5 deletions claude-agent-sdk/tests/test_app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ class TestAppHomeOpened:
def setup_method(self):
self.fake_client = Mock(AsyncWebClient)
self.fake_client.views_publish = AsyncMock()
self.fake_client.assistant_threads_setSuggestedPrompts = AsyncMock()
self.fake_set_suggested_prompts = AsyncMock()
self.fake_context = Mock(AsyncBoltContext)
self.fake_context.user_id = "U123"
self.fake_context.set_suggested_prompts = self.fake_set_suggested_prompts

@pytest.mark.asyncio
async def test_publishes_home_view_when_tab_is_home(self):
Expand All @@ -31,7 +32,7 @@ async def test_publishes_home_view_when_tab_is_home(self):
kwargs = self.fake_client.views_publish.call_args.kwargs
assert kwargs["user_id"] == "U123"
assert kwargs["view"]["type"] == "home"
self.fake_client.assistant_threads_setSuggestedPrompts.assert_not_called()
self.fake_set_suggested_prompts.assert_not_called()

@pytest.mark.asyncio
async def test_sets_suggested_prompts_when_tab_is_messages(self):
Expand All @@ -42,9 +43,8 @@ async def test_sets_suggested_prompts_when_tab_is_messages(self):
logger=test_logger,
)

self.fake_client.assistant_threads_setSuggestedPrompts.assert_called_once()
kwargs = self.fake_client.assistant_threads_setSuggestedPrompts.call_args.kwargs
assert kwargs["channel_id"] == "D123"
self.fake_set_suggested_prompts.assert_called_once()
kwargs = self.fake_set_suggested_prompts.call_args.kwargs
assert isinstance(kwargs["prompts"], list)
self.fake_client.views_publish.assert_not_called()

Expand Down
5 changes: 2 additions & 3 deletions openai-agents-sdk/listeners/events/app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ def handle_app_home_opened(
"""
try:
if event.get("tab") == "messages":
client.assistant_threads_setSuggestedPrompts(
channel_id=event["channel"],
title="How can I help you today?",
context.set_suggested_prompts(
prompts=SUGGESTED_PROMPTS,
title="How can I help you today?",
)
# TODO(agent-dm-messages-tab): handle app_context_changed once Bolt supports it
return
Expand Down
2 changes: 1 addition & 1 deletion openai-agents-sdk/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
slack-sdk==3.43.0
slack-bolt==1.29.0
../vendor/slack_bolt-1.29.0+pr1549.812f7c3-py2.py3-none-any.whl
slack-cli-hooks==0.3.0
openai-agents==0.18.0
python-dotenv==1.2.2
Expand Down
9 changes: 5 additions & 4 deletions openai-agents-sdk/tests/test_app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
class TestAppHomeOpened:
def setup_method(self):
self.fake_client = Mock(WebClient)
self.fake_set_suggested_prompts = Mock()
self.fake_context = Mock(BoltContext)
self.fake_context.user_id = "U123"
self.fake_context.set_suggested_prompts = self.fake_set_suggested_prompts

def test_publishes_home_view_when_tab_is_home(self):
handle_app_home_opened(
Expand All @@ -27,7 +29,7 @@ def test_publishes_home_view_when_tab_is_home(self):
kwargs = self.fake_client.views_publish.call_args.kwargs
assert kwargs["user_id"] == "U123"
assert kwargs["view"]["type"] == "home"
self.fake_client.assistant_threads_setSuggestedPrompts.assert_not_called()
self.fake_set_suggested_prompts.assert_not_called()

def test_sets_suggested_prompts_when_tab_is_messages(self):
handle_app_home_opened(
Expand All @@ -37,9 +39,8 @@ def test_sets_suggested_prompts_when_tab_is_messages(self):
logger=test_logger,
)

self.fake_client.assistant_threads_setSuggestedPrompts.assert_called_once()
kwargs = self.fake_client.assistant_threads_setSuggestedPrompts.call_args.kwargs
assert kwargs["channel_id"] == "D123"
self.fake_set_suggested_prompts.assert_called_once()
kwargs = self.fake_set_suggested_prompts.call_args.kwargs
assert isinstance(kwargs["prompts"], list)
self.fake_client.views_publish.assert_not_called()

Expand Down
5 changes: 2 additions & 3 deletions pydantic-ai/listeners/events/app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ def handle_app_home_opened(
"""
try:
if event.get("tab") == "messages":
client.assistant_threads_setSuggestedPrompts(
channel_id=event["channel"],
title="How can I help you today?",
context.set_suggested_prompts(
prompts=SUGGESTED_PROMPTS,
title="How can I help you today?",
)
# TODO(agent-dm-messages-tab): handle app_context_changed once Bolt supports it
return
Expand Down
2 changes: 1 addition & 1 deletion pydantic-ai/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
slack-sdk==3.43.0
slack-bolt==1.29.0
../vendor/slack_bolt-1.29.0+pr1549.812f7c3-py2.py3-none-any.whl
slack-cli-hooks==0.3.0
pydantic-ai[openai,anthropic]==1.107.0
python-dotenv==1.2.2
Expand Down
9 changes: 5 additions & 4 deletions pydantic-ai/tests/test_app_home_opened.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
class TestAppHomeOpened:
def setup_method(self):
self.fake_client = Mock(WebClient)
self.fake_set_suggested_prompts = Mock()
self.fake_context = Mock(BoltContext)
self.fake_context.user_id = "U123"
self.fake_context.set_suggested_prompts = self.fake_set_suggested_prompts

def test_publishes_home_view_when_tab_is_home(self):
handle_app_home_opened(
Expand All @@ -27,7 +29,7 @@ def test_publishes_home_view_when_tab_is_home(self):
kwargs = self.fake_client.views_publish.call_args.kwargs
assert kwargs["user_id"] == "U123"
assert kwargs["view"]["type"] == "home"
self.fake_client.assistant_threads_setSuggestedPrompts.assert_not_called()
self.fake_set_suggested_prompts.assert_not_called()

def test_sets_suggested_prompts_when_tab_is_messages(self):
handle_app_home_opened(
Expand All @@ -37,9 +39,8 @@ def test_sets_suggested_prompts_when_tab_is_messages(self):
logger=test_logger,
)

self.fake_client.assistant_threads_setSuggestedPrompts.assert_called_once()
kwargs = self.fake_client.assistant_threads_setSuggestedPrompts.call_args.kwargs
assert kwargs["channel_id"] == "D123"
self.fake_set_suggested_prompts.assert_called_once()
kwargs = self.fake_set_suggested_prompts.call_args.kwargs
assert isinstance(kwargs["prompts"], list)
self.fake_client.views_publish.assert_not_called()

Expand Down
Binary file added vendor/slack_bolt-1.29.0+pr1549.812f7c3-py2.py3-none-any.whl
View file
Open in desktop
Binary file not shown.