Skip to content

seeweb-updateyml#149

Merged
kyuds merged 1 commit intoskypilot-org:masterfrom
Seeweb:skypilot-catalog-seeweb-01
Apr 10, 2026
Merged

seeweb-updateyml#149
kyuds merged 1 commit intoskypilot-org:masterfrom
Seeweb:skypilot-catalog-seeweb-01

Conversation

@massaindustries
Copy link
Copy Markdown
Contributor

ALREADY MERGED

[x] Added update-catalog.yml

Copy link
Copy Markdown

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

- name: Run fetch_seeweb
id: fetch_catalogs
env:
SEEWEB_API_KEY: ${{ secrets.SEEWEB_API_KEY }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the SEEWEB_API_KEY already configured in this repo?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. @massaindustries could I reach out to you on slack?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, I gave the seeweb api key to Yelei Wu. I'm on the skypilot channel on slack

@aylei
Copy link
Copy Markdown

aylei commented Sep 16, 2025

cc @romilbhardwaj for taking a look

Copy link
Copy Markdown

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@massaindustries
Copy link
Copy Markdown
Contributor Author

@Michaelvll

Copy link
Copy Markdown
Collaborator

@kyuds kyuds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end except for the two comments. Would love to get this merged @massaindustries !

version: "latest"
python-version: "3.10"

- name: Install yq
Copy link
Copy Markdown
Collaborator

@kyuds kyuds Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at other implementations of the update yml that are working, we don't need to install yq. its already available. refer to aws and gcp catalogs for instance

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- name: Run fetch_seeweb
id: fetch_catalogs
env:
SEEWEB_API_KEY: ${{ secrets.SEEWEB_API_KEY }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. @massaindustries could I reach out to you on slack?

@massaindustries massaindustries requested review from aylei and kyuds April 3, 2026 11:34
@massaindustries massaindustries force-pushed the skypilot-catalog-seeweb-01 branch from 961769e to 5f61352 Compare April 3, 2026 12:13
@kyuds kyuds merged commit 968fdd0 into skypilot-org:master Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants