add http proxy vanflow record to Link records#2446
Conversation
fgiorgetti
left a comment
There was a problem hiding this comment.
LGTM @c-kruse, but I'd like to get your confirmation as well.
| httpProxy: | ||
| type: string | ||
| nullable: true | ||
| description: When connected, whether this link uses an HTTP proxy. |
There was a problem hiding this comment.
I am iffy on the raw pass-through string here, would prefer a boolean "httpProxy" to "yes/no" or a "proxyProtocol" enum with "NONE,HTTP" were we to ever entertain another option like SOCKS5 or something (I don't remember whether or not we've decided that makes any sense.)
Also the description could use some work: e.g. "true when the link connection is established through an HTTP proxy"
There was a problem hiding this comment.
Thanks. I'll switch it to a boolean for now. I can bring it up in our meeting on Tuesday to see if there was a decision or thoughts about using other protocols and if it makes sense to switch to an enum.
9b5f76e to
464fd6f
Compare
464fd6f to
58a04cb
Compare
added a new attribute on the LinkRecord to pick up the new HTTP_PROXY record from the router that indicates if a proxy is being used on the link
Fixes #2361