Skip to content

add http proxy vanflow record to Link records#2446

Merged
JPadovano1483 merged 3 commits into
skupperproject:mainfrom
JPadovano1483:james-proxy-record
May 26, 2026
Merged

add http proxy vanflow record to Link records#2446
JPadovano1483 merged 3 commits into
skupperproject:mainfrom
JPadovano1483:james-proxy-record

Conversation

@JPadovano1483
Copy link
Copy Markdown
Contributor

added a new attribute on the LinkRecord to pick up the new HTTP_PROXY record from the router that indicates if a proxy is being used on the link

Fixes #2361

Copy link
Copy Markdown
Member

@fgiorgetti fgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @c-kruse, but I'd like to get your confirmation as well.

Copy link
Copy Markdown
Contributor

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plumbing all looks good, just a couple notes on what we want the API spec to be.

Comment thread cmd/network-observer/spec/openapi.yaml Outdated
httpProxy:
type: string
nullable: true
description: When connected, whether this link uses an HTTP proxy.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am iffy on the raw pass-through string here, would prefer a boolean "httpProxy" to "yes/no" or a "proxyProtocol" enum with "NONE,HTTP" were we to ever entertain another option like SOCKS5 or something (I don't remember whether or not we've decided that makes any sense.)

Also the description could use some work: e.g. "true when the link connection is established through an HTTP proxy"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll switch it to a boolean for now. I can bring it up in our meeting on Tuesday to see if there was a decision or thoughts about using other protocols and if it makes sense to switch to an enum.

Copy link
Copy Markdown
Contributor

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@JPadovano1483 JPadovano1483 merged commit e7883d1 into skupperproject:main May 26, 2026
2 checks passed
@JPadovano1483 JPadovano1483 deleted the james-proxy-record branch May 26, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Observability support for HTTP Proxy tunnel

3 participants