Fix #2 (failure to detect undefined labels)#3
Open
TC01 wants to merge 1 commit intoskilldrick:masterfrom
Open
Conversation
… false when detecting undefined labels in checkAbsolute* functions
Collaborator
|
I think the idea of 0x1234 is to be a placeholder for forward references, so the code comes out the right size and labels are in the right place on the second pass. Can you confirm that your fix works with code that has a forward reference? Do all the example easy6502 programs still work? |
Author
|
All the example programs with labels from here still compile and run: http://skilldrick.github.io/easy6502/ I thought that it might be for something like that as well; however a quick search through the source code didn't turn up any other occurrences of 0x1234. So if it is meant to do something like that, I'm not entirely sure how it is doing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I already posted about this on the bug report: since no one has responded there I figured I'd open a pull request.
This should prevent undefined labels from being silently ignored and replaced with a jump to 0x1234. All it does is make the assembler return an error when an undefined label is encountered instead of pretending everything was successful.
If I had to guess, I'd say 0x1234 is being pushed so it can be detected later from elsewhere. However, the code to actually do this doesn't seem to ever have been implemented, so this is better than nothing.