Add missing optparse_long_only() and useful macros for Windows, also separate definition and implementation.#11
Add missing optparse_long_only() and useful macros for Windows, also separate definition and implementation.#11eeeeeeeelias wants to merge 3 commits intoskeeto:masterfrom
Conversation
| * field to 0 after initialization. | ||
| */ | ||
|
|
||
| #ifndef OPTPARSE_IMPLEMENTATION |
There was a problem hiding this comment.
It doesn't make sense to exclude function declarations and macro definitions when implementation is asked for.
AFAIK, forward declaration is a good practice when writing C. It not only guarentees the consistency between the header and the implementation, but also enables calling another function defined below the current one.
| #define TCHAR char | ||
| #define _TEXT(x) x | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Are TCHAR and TEXT() macros still relevent? Could TCHAR be converted to int implicitly?
I'm not familiar with Windows. Please feal free to correct me.
https://docs.microsoft.com/en-us/windows/win32/learnwin32/working-with-strings
|
It doesn't look like short options work properly when using Here, ambiguity doesn't work as intended: |
No description provided.