This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Support incrementing or decrementing Counters by 0#65
Open
todd wants to merge 1 commit intosivy:masterfrom
Open
Support incrementing or decrementing Counters by 0#65todd wants to merge 1 commit intosivy:masterfrom
todd wants to merge 1 commit intosivy:masterfrom
Conversation
todd
force-pushed
the
increment_decrement_by_0
branch
from
5c77803 to
b47c00c
Compare
Author
|
Test failures are for very outdated versions of Node failing to install packages on Travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to support incrementing or decrementing a Counter by 0. The current code
value || 1wherevalue = 0will always evaluate to 1. This changes the behavior to support 0, but still default to 1 whenvalueisundefinedornull.