Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

using options object and handle error inside module when handleError …#55

Open
doron2402 wants to merge 1 commit intosivy:masterfrom
doron2402:master
Open

using options object and handle error inside module when handleError …#55
doron2402 wants to merge 1 commit intosivy:masterfrom
doron2402:master

Conversation

@doron2402
Copy link

  1. change options to an object.
  2. add handleError (we had issue on production)

the issue was that one of our statsd server url was change and the whole app crash
{ [Error: getaddrinfo ENOTFOUND] code: 'ENOTFOUND', errno: 'ENOTFOUND', syscall: 'getaddrinfo' }

I fix it using domain but that's seems like a good solution that you could listen to the socket and disable it from returning an error.

@doron2402
Copy link
Author

@sivy ^^ want to merge it? it can help us a lot.

Thanks

@doron2402
Copy link
Author

@sivy if you decide to merge to those changes I'll have to update the README file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant