feat: added ical api#40
Merged
sitepark-becker merged 17 commits intomainfrom Jan 24, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
============================================
+ Coverage 99.89% 99.90% +0.01%
- Complexity 247 281 +34
============================================
Files 13 16 +3
Lines 927 1031 +104
============================================
+ Hits 926 1030 +104
Misses 1 1 ☔ View full report in Codecov by Sentry. |
| if (!empty($id)) { | ||
| return $this->createICalResponseById($id); | ||
| } | ||
| $res = new JsonResponse(['error' => 'Either provide an \'id\' or a \'location\' of a resource']); |
Member
There was a problem hiding this comment.
To have a standardized error format. I used this in the form-bundle api-problem-bundle. See also here.
sitepark-veltrup
approved these changes
Jan 22, 2025
Member
|
PHP 8.4: Unfortunately not yet supported. |
sitepark-veltrup
approved these changes
Jan 23, 2025
Member
|
In order for "verify" to run without errors, php 8.4 must be removed from the workflow: https://github.com/sitepark/atoolo-events-calendar-bundle/blob/main/.github/workflows/verify.yml#L16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/api/icalthat creates an.icalfile from the scheduling data of a given resource. Expects one of two parameters:location: the controller will load the resource directly from the given location.id: the controller will search for the resource by the id. Useful for external resources.iCalUrlto the graphql typeEventTeaser+ Resolvers