Closed
Conversation
The test_modifiable_text_special_pre and test_modifiable_text_special_listing tests had identical structure, differing only in tag name. Consolidate them into a single data-provider-driven test. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
TEXTAREA, like PRE and LISTING, ignores the first newline in its content. Fold the separate TEXTAREA test into the shared data provider, also adding an assertEqualHTML check it previously lacked. Use advance_n_tokens to handle the navigation difference (TEXTAREA is a raw text element reached in one next_token() call vs two for PRE/LISTING). https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
TEXTAREA is a raw text element with different navigation semantics and should remain a separate test. Only PRE and LISTING share the same test structure. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @claude. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
changed the base branch from
trunk
to
html-api/set-mod-html-leading-newlines
…a data provider The test_modifiable_text_special_pre and test_modifiable_text_special_listing tests had identical structure, differing only in tag name. Consolidate them into a single data-provider-driven test. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
…LISTING Replace the monolithic test_modifiable_text_special_pre_leading_whitespace with a data-provider-driven test that runs the same 4 cases for both PRE and LISTING elements. This also addresses the @todo on the former LISTING test about adding leading whitespace tests. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
…l_pre_tags Loop over data_modifiable_text_special_pre_tags() to produce tag names, so adding a new tag to that data provider automatically covers the leading whitespace cases too. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.