Add star button to activity description#132
Open
snowmonkey18 wants to merge 17 commits intosipb:mainfrom
Open
Conversation
This avoids the nesting indentation that comes from multiple sequential requests.
This resolves one of the TODO comments, but it is useful since it means that the URL in the address bar matches what is shown on the page.
To avoid try/catch.
IAP or summer of a year where those terms were not scraped separately should redirect silently to spring or fall of that year, and otherwise we try to redirect (eventually with some sort of notice to the user) to the same semester of the current year.
cjquines
reviewed
Jan 30, 2025
Member
cjquines
left a comment
cjquines
left a comment
There was a problem hiding this comment.
i would kinda almost prefer it to not be in classtable but i'd leave that to others
Comment on lines
+420
to
+427
| const refreshCells = () => { | ||
| gridRef.current?.api?.refreshCells({ | ||
| force: true, | ||
| columns: ["number"], | ||
| }); | ||
| }; | ||
| window.addEventListener("refreshStarCells", refreshCells); | ||
| return () => window.removeEventListener("refreshStarCells", refreshCells); |
Member
There was a problem hiding this comment.
thought: this is very cursed but i'm not sure what else can be done about it
maybe just add a comment on both sides...
Collaborator
There was a problem hiding this comment.
Maybe we could pass gridRef up into App and back down into ClassTable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds star button to ActivityDescription, since someone requested to be able to star a class when its ActivityDescription is up, without having to search for it on the ClassTable.