Add SystemParameters#1127
Open
ccgsnet wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes DAS runtime defaults in
config/das.jsonviaSystemParametersandSystemParametersSingleton. Agent proxies load merged params fromagents.<name>.params(withbase_querylayered where applicable) instead of hardcoded values or a separateclient.json.SystemParameters— parsesagents.*.paramsintoProperties; agent getters (get_query_agent_params, etc.)SystemParametersValidation— versioned schema (1.0, aligned withschema_versionindas.json); required keys, unknown keys, and type checksbus_node/bus_client— both usedas.json;bus_clientdefaults toconfig/das.jsonand dropsclient.jsonsystem_parameters_test, shared fixture intest_commons/TestSystemParams.hConfig shape
agents.base_query.paramsholds shared query defaults; each service adds/overrides its ownagents.<agent>.params.Examples
busnode
Start the query engine (endpoint/ports from
agents.querywhen using--config):make run-busnode OPTIONS="--config=config/das.json --service=query-engine"Start evolution agent:
make run-busnode OPTIONS="--config=config/das.json --service=evolution-agent"busclient
Pattern-matching query against query-engine:
make run-client OPTIONS="--client=query-engine --query=LINK_TEMPLATE Expression 3 NODE Symbol Similarity VARIABLE V1 VARIABLE V2"Test
make bazel test //tests/cpp:system_parameters_testquery-engine+ run querybusclientexample aboveagents.*.paramsfail at startup with a clear validation error