Skip to content

Add SystemParameters#1127

Open
ccgsnet wants to merge 2 commits into
masterfrom
system-parameters
Open

Add SystemParameters#1127
ccgsnet wants to merge 2 commits into
masterfrom
system-parameters

Conversation

@ccgsnet
Copy link
Copy Markdown
Collaborator

@ccgsnet ccgsnet commented May 28, 2026

Summary

Centralizes DAS runtime defaults in config/das.json via SystemParameters and SystemParametersSingleton. Agent proxies load merged params from agents.<name>.params (with base_query layered where applicable) instead of hardcoded values or a separate client.json.

  • SystemParameters — parses agents.*.params into Properties; agent getters (get_query_agent_params, etc.)
  • SystemParametersValidation — versioned schema (1.0, aligned with schema_version in das.json); required keys, unknown keys, and type checks
  • bus_node / bus_client — both use das.json; bus_client defaults to config/das.json and drops client.json
  • Testssystem_parameters_test, shared fixture in test_commons/TestSystemParams.h

Config shape

agents.base_query.params holds shared query defaults; each service adds/overrides its own agents.<agent>.params.

Examples

busnode

Start the query engine (endpoint/ports from agents.query when using --config):

make run-busnode OPTIONS="--config=config/das.json --service=query-engine"

Start evolution agent:

make run-busnode OPTIONS="--config=config/das.json --service=evolution-agent"

busclient

Pattern-matching query against query-engine:

make run-client OPTIONS="--client=query-engine --query=LINK_TEMPLATE Expression 3 NODE Symbol Similarity VARIABLE V1 VARIABLE V2"

Test

  • make bazel test //tests/cpp:system_parameters_test
  • Start query-engine + run query busclient example above
  • Confirm invalid/unknown keys in agents.*.params fail at startup with a clear validation error

@ccgsnet ccgsnet requested a review from andre-senna May 28, 2026 22:21
@ccgsnet ccgsnet self-assigned this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant