Skip to content

Ensures that multiple tags are being honored, instead of just getting the first one#1284

Open
Johan3F wants to merge 2 commits intosimulot:developfrom
Johan3F:fix/multiple-tags-not-honored
Open

Ensures that multiple tags are being honored, instead of just getting the first one#1284
Johan3F wants to merge 2 commits intosimulot:developfrom
Johan3F:fix/multiple-tags-not-honored

Conversation

@Johan3F
Copy link
Copy Markdown

@Johan3F Johan3F commented Jan 8, 2026

It relates to this issue: #1279

When merging tags, only the name was being used, but when the tags are loaded from the json sidecar file, only the value is expected, having only the name set to "".
Aside from that, the value is also used for manage the asset tags for the same reason.

A tiny cleanup of a for loop that was initializing a variable that was never used

@Johan3F Johan3F requested a review from simulot as a code owner January 8, 2026 20:47
@kuzyn
Copy link
Copy Markdown

kuzyn commented Jan 27, 2026

Would that possibly also fix the issue where when using the --folder-as-tags=true switch, if an image appears in two folders, only the tag from the first encountered folder is associated to the image? See #1069

@Johan3F
Copy link
Copy Markdown
Author

Johan3F commented Jan 28, 2026

hi @kuzyn.
I've been running some tests and not, this wouldn't cover that.
For what I've seen, that bug needs some extra handling on the:

// run.go file l384
	case AlreadyProcessed: // SHA1 already processed
[...]
	case SameOnServer:
[...]
	case BetterOnServer: // and manage albums
[...]

I've tried to create a quick solution for that bug, but it's a bit more involved and it might require some decision making from the maintainers that I'm able to do on my own (Is it considered then discarded? it currently is, but if that's fixed, wouldn't it be?)

@johan-van-de-walle johan-van-de-walle force-pushed the fix/multiple-tags-not-honored branch from 2b7abe8 to 00ce1d5 Compare February 18, 2026 07:49
@johan-van-de-walle johan-van-de-walle force-pushed the fix/multiple-tags-not-honored branch from 00ce1d5 to 2f9373b Compare February 18, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants