Ensures that multiple tags are being honored, instead of just getting the first one#1284
Open
Johan3F wants to merge 2 commits intosimulot:developfrom
Open
Ensures that multiple tags are being honored, instead of just getting the first one#1284Johan3F wants to merge 2 commits intosimulot:developfrom
Johan3F wants to merge 2 commits intosimulot:developfrom
Conversation
|
Would that possibly also fix the issue where when using the |
Author
|
hi @kuzyn. // run.go file l384
case AlreadyProcessed: // SHA1 already processed
[...]
case SameOnServer:
[...]
case BetterOnServer: // and manage albums
[...]I've tried to create a quick solution for that bug, but it's a bit more involved and it might require some decision making from the maintainers that I'm able to do on my own (Is it considered then discarded? it currently is, but if that's fixed, wouldn't it be?) |
2b7abe8 to
00ce1d5
Compare
00ce1d5 to
2f9373b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It relates to this issue: #1279
When merging tags, only the name was being used, but when the tags are loaded from the json sidecar file, only the value is expected, having only the name set to
"".Aside from that, the value is also used for manage the asset tags for the same reason.
A tiny cleanup of a for loop that was initializing a variable that was never used