[Shadow] APL improvements banking Void Volley and pooling insanity for VF - #11687
Merged
seanpeters86 merged 2 commits intoAug 10, 2026
Merged
Conversation
seanpeters86
approved these changes
Aug 10, 2026
seanpeters86
merged commit Aug 10, 2026
297fb2a
into
simulationcraft:midnight
15 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement to spriest APL
One change is when we get closer to voidform we can try to save up a bit of insanity as long as we keep the same SWM uptime casting SWM inside of voidform will be more dmg and will also slightly extend VF
Second change is that since the void volley buff from our 4pc has such a long duration we are in no rush to spend it as soon as we get it, and could wait to spend it at a better time, for archon this means trying to spend them inside our resonant energy buff. For VW the dps increase mainly seems to come from deprioritizing it which makes us cast some more SW:D on execute.
The insanity pooling is only a dps increase on ST as with more targets it seems better to just cast it and thus have higher spread uptime on it. So I had to add some extra clauses to avoid it regressing the dungeon slice sim mainly the
target.time_to_die<25|active_enemies>1Void Volley
Insanity Pool
Both
Void Volley
Insanity Pool
Both
ST: https://mimiron.raidbots.com/simbot/report/gcXqiUusN7P2JLZKTqTj36
2T: https://mimiron.raidbots.com/simbot/report/on5pijDHHtZE9AUxLgn3aH
3T: https://mimiron.raidbots.com/simbot/report/cMaEWD7cNyNrMrEtW6YjvY
8T: https://mimiron.raidbots.com/simbot/report/bPZYHYnG8VvSage926wqbJ
Dslice: https://mimiron.raidbots.com/simbot/report/wgZKmhXddZrwDR1i3TgmRk