feat: Adds the ability to use spaces in simc input#11182
Open
thevinter wants to merge 1 commit intosimulationcraft:midnightfrom
Open
feat: Adds the ability to use spaces in simc input#11182thevinter wants to merge 1 commit intosimulationcraft:midnightfrom
thevinter wants to merge 1 commit intosimulationcraft:midnightfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds whitespace stripping outside of double-quoted regions to both the C++ option parser (option.cpp) and the Python APL converter (ConvertAPL.py). This allows users to write more readable .simc files using spaces
e.g.,
instead of
Important, while minor this is still a breaking change
This removes support for same-line option definitions that relied on spaces as token separators (e.g.,
name=Vinter race=human).Because spaces are now stripped, multiple definitions on one line will be merged into a single token. Each option must now be on its own line.
This tradeoff is intentional since same-line definitions aren't used anywhere in the current profiles, and allowing spaces in input significantly improves readability and lowers the barrier for others editing .simc files.