[Demon Hunter] Fix sigil expression crash when spell is not known#11177
Open
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Open
[Demon Hunter] Fix sigil expression crash when spell is not known#11177taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Conversation
Sigil expressions (placed, activation_time, delay) throw "No expression found" at init when the sigil spell is not talented. The inner sigil action is only created when the talent is active, so create_expression falls through to the parent which doesn't handle sigil-specific names. Return constant 0 when the sigil is null. Fixes all five sigil types.
taherbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sigil expressions (
placed,sigil_placed,activation_time,delay) throw "No expression found" at init time when referenced viaaction.sigil_name.placedon a character that doesn't have the sigil spell. The inner sigil background action is only created when the talent/spell is active, socreate_expressionfalls through to the parent class which doesn't handle sigil-specific expression names.Returns constant 0 when the sigil pointer is null. Applied to all five sigil types for consistency.