Skip to content

fix: crucible of erratic energies never procs for melee specs #11160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craned70 wants to merge 1 commit into
base: midnight
Choose a base branch
from
+4 −0
Open

fix: crucible of erratic energies never procs for melee specs #11160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions engine/player/unique_gear_midnight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,6 +2912,10 @@ void crucible_of_erratic_energies( special_effect_t& effect )
effect.custom_buff = buff;

effect.proc_flags2_ = PF2_LANDED;
// Spell data proc_flags (0x00015500) has no melee ability types. The driver has
// SX_ONLY_PROC_FROM_CLASS_ABILITIES set, which gates procs on allow_class_ability_procs,
// but the callback is never registered for melee actions without this addition.
effect.proc_flags_ = effect.driver()->proc_flags() | PF_MELEE_ABILITY;

new dbc_proc_callback_t( effect.player, effect );
}
Expand Down