Skip to content

feat(quickbooks): complete webhook trigger matrix - #6248

Open
BillLeoutsakosvl346 wants to merge 3 commits into
feat/quickbooks-08-webhook-corefrom
feat/quickbooks-09-webhook-matrix
Open

feat(quickbooks): complete webhook trigger matrix#6248
BillLeoutsakosvl346 wants to merge 3 commits into
feat/quickbooks-08-webhook-corefrom
feat/quickbooks-09-webhook-matrix

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • expand the QuickBooks trigger dropdown from 7 representative entities to all 29 documented webhook entities
  • cover all 101 supported entity/action combinations with table-driven validation
  • reuse the app-level callback, signature verification, bounded ingress job, realm routing, and dispatcher from PR feat(quickbooks): add core webhook triggers #6245
  • keep Preferences as a fixed Updated trigger without a redundant action selector

Validation

  • 12 QuickBooks-related test files / 336 tests pass
  • Sim TypeScript type-check passes
  • tool metadata, API contracts, icons, client boundary, and registry boundary checks pass
  • repository format and lint checks pass (with only pre-existing Zoho Desk warnings)
  • documentation generation passes with no unrelated retained churn
  • independent max-reasoning review ran add-trigger and validate-trigger and gave a clean approval

Notes

  • stacked on PR feat(quickbooks): add core webhook triggers #6245 (feat/quickbooks-08-webhook-core)
  • no new webhook runtime architecture or shared trigger changes are introduced in this layer
  • live Intuit callback acceptance still requires a configured public callback and QUICKBOOKS_WEBHOOK_VERIFIER_TOKEN; signed fixtures cover the delivery contract locally
  • do not merge automatically

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 4, 2026 8:51am

Request Review

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large trigger surface area and event-matching logic affect which workflows fire on Intuit callbacks, but changes follow the existing table-driven pattern and reuse the stacked webhook runtime without new ingress architecture.

Overview
Expands QuickBooks workflow triggers from 7 representative entities to all 29 Intuit webhook entities, covering 101 entity/action combinations through the shared QUICKBOOKS_TRIGGER_DEFINITIONS table in utils.ts.

Each new entity gets a thin trigger module (shared sub-blocks, outputs, and webhook headers), registration in the trigger registry, entries on the QuickBooks block’s triggers.available list, and matching updates in integrations.json and the QuickBooks integration docs.

Matching and UX tweaks: isQuickBooksEventMatch skips user action filtering when a trigger only supports one action (e.g. Preferences updated). Preferences Updated uses buildQuickBooksSingleEventTriggerSubBlocks with no eventTypes selector. Setup instructions now mention enabling webhook notifications in the Intuit Developer Portal.

Tests assert parity across definitions, block access, and registry, and validate all 101 supported CloudEvent patterns plus rejection of unsupported actions.

Reviewed by Cursor Bugbot for commit bed4b32. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR expands QuickBooks webhook support from seven representative entities to the complete 29-entity, 101-action matrix while retaining the existing webhook ingestion and dispatch architecture.

  • Adds entity-specific trigger definitions and registration across the QuickBooks block, trigger registry, integration metadata, and generated documentation.
  • Introduces shared factory logic for action selectors, setup instructions, outputs, and runtime event matching.
  • Handles Preferences as a fixed Updated event without exposing a redundant action selector.
  • Adds table-driven parity and matching coverage for every supported entity/action combination.

Confidence Score: 5/5

The PR appears safe to merge, with the expanded trigger matrix consistently represented across runtime, registry, block, metadata, test, and documentation surfaces.

The new triggers reuse the established ingestion path, their identifiers and conditional subblocks remain aligned across consumers, and the matching tests cover every declared entity/action combination without revealing a concrete reachable failure.

Important Files Changed

Filename Overview
apps/sim/triggers/quickbooks/utils.ts Defines the centralized 29-entity webhook matrix, shared trigger subblocks, setup instructions, and entity/action matching logic without an identified defect.
apps/sim/triggers/quickbooks/quickbooks.test.ts Adds table-driven parity and matching checks for all 29 triggers and 101 supported entity/action combinations.
apps/sim/triggers/quickbooks/index.ts Exports the complete QuickBooks trigger set consistently with the registry and block catalogs.
apps/sim/triggers/registry.ts Registers all newly supported QuickBooks trigger IDs with no missing or duplicate registration found.
apps/sim/blocks/blocks/quickbooks.ts Exposes all 29 triggers and their conditional subblocks through the QuickBooks block using the established shared-field pattern.
apps/sim/lib/integrations/integrations.json Updates integration metadata to advertise the complete trigger catalog and matching trigger count.
apps/docs/content/docs/en/integrations/quickbooks.mdx Documents the expanded trigger matrix and the common normalized webhook output contract.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  QB[QuickBooks webhook] --> Parser[Parse CloudEvent type]
  Parser --> Match[Match entity and configured action]
  Match --> Registry[Resolve one of 29 trigger IDs]
  Registry --> Dispatch[Existing realm-aware dispatcher]
  Dispatch --> Workflow[Execute configured workflow]
Loading

Reviews (1): Last reviewed commit: "fix(quickbooks): clarify webhook setup" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant