fix(md-render): fix markdown rendering in file viewer#4458
fix(md-render): fix markdown rendering in file viewer#4458waleedlatif1 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Tables UI interactions and layout are refined. Boolean cells only toggle when clicking directly on the checkbox area, double-click editing is disabled for boolean cells, row selection hit targets are widened and made more keyboard-accessible, and the column config sidebar width is made responsive via a shared Minor UX tweaks. New markdown file creation suppresses the upload success toast via Reviewed by Cursor Bugbot for commit 32d2300. Configure here. |
Greptile SummaryThis PR fixes a collection of markdown rendering bugs in the file viewer and refines the tables UI. All changes are isolated, targeted bug fixes with no new abstractions introduced.
Confidence Score: 5/5Safe to merge — all changes are isolated UI-layer bug fixes with no shared state, API, or data-model impact. The markdown fixes are purely presentational (class names, React element cloning). The boolean-cell toggle refactor correctly narrows the click target using DOM traversal and the new No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Table cell click\n(DataRow onClick)"] --> B{"column.type\n=== 'boolean'?"}
B -- No --> C["Clear editing cell\n(normal path)"]
B -- Yes --> D{"options.toggleBoolean?\n(clicked [data-boolean-cell-toggle]?)"}
D -- No --> E["Return — no-op"]
D -- Yes --> F{"canEditRef.current?"}
F -- No --> E
F -- Yes --> G["toggleBooleanCell()"]
H["Table cell dblclick\n(handleCellDoubleClick)"] --> I{"column.type\n=== 'boolean'?"}
I -- Yes --> J["Return early — no edit mode"]
I -- No --> K["Enter cell edit mode\n(select text, set editingCell)"]
subgraph "cell-content.tsx"
L["span[data-boolean-cell-toggle]"] --> M["Checkbox\n(pointer-events-none)"]
end
Reviews (2): Last reviewed commit: "fix(md-render): fix cloneElement type er..." | Re-trigger Greptile |
…ements - Fix TypeScript build error: type isValidElement<Record<string, unknown>> so cloneElement accepts data-block prop - Column sidebar: use CSS min() for responsive width instead of fixed 400px - Table: boolean cell toggle only fires when clicking the checkbox element directly (via data-boolean-cell-toggle), not anywhere on the cell - Table: double-clicking a boolean cell no longer opens edit mode - Table: move row-select mousedown to the <td> to widen the hit target - Table: run/stop button prevents row-select on mousedown - Table: SelectAllCheckbox made keyboard-accessible; checkbox is pointer-events-none
|
Fixed the CI build failure: |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 32d2300. Configure here.
Summary
data-blockprop injection into Streamdown'sprecomponent)inlineCodehandler (unclosed backticks no longer produce oversized code elements)not-italicto all<pre>and inline<code>elements so code inside blockquotes doesn't inherit italic styling<th>font size to match<td>(13px vs 12px)Type of Change
Testing
Tested manually
Checklist