Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Add per-deployment extraVolumes and extraVolumeMounts for app, realtime, and ollama
  • Allows users to mount volumes to specific deployments instead of all deployments
  • Maintains backward compatibility with global extraVolumes

Type of Change

  • New feature / enhancement

Testing

Tested with helm lint --strict and helm template with various volume configurations

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 22, 2026 7:26pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

This PR adds per-deployment extraVolumes and extraVolumeMounts configuration options for the app, realtime, and ollama deployments, allowing users to mount volumes to specific deployments instead of mounting them globally to all deployments.

The implementation:

  • Adds app.extraVolumes, app.extraVolumeMounts, realtime.extraVolumes, realtime.extraVolumeMounts, ollama.extraVolumes, and ollama.extraVolumeMounts to values.yaml
  • Updates deployment templates to merge both global (extraVolumes/extraVolumeMounts) and per-deployment volumes using proper conditional logic
  • Maintains backward compatibility with existing global extraVolumes and extraVolumeMounts configuration
  • Integrates cleanly with ollama's existing persistence volume configuration

The changes follow established Helm patterns for volume configuration and maintain consistency across all three deployments.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes follow standard Helm template patterns for conditional volume configuration, maintain backward compatibility, and use proper YAML indentation. The implementation is consistent across all affected deployments and integrates well with existing volume logic.
  • No files require special attention

Important Files Changed

Filename Overview
helm/sim/templates/deployment-app.yaml Added per-deployment extraVolumes and extraVolumeMounts support with proper conditional logic merging global and deployment-specific volumes
helm/sim/templates/deployment-realtime.yaml Added per-deployment extraVolumes and extraVolumeMounts support with proper conditional logic merging global and deployment-specific volumes
helm/sim/templates/deployment-ollama.yaml Added per-deployment extraVolumes and extraVolumeMounts support integrated with existing persistence volume logic
helm/sim/values.yaml Added extraVolumes and extraVolumeMounts configuration options to app, realtime, and ollama sections with descriptive comments

Sequence Diagram

sequenceDiagram
    participant User as Helm User
    participant Values as values.yaml
    participant Templates as Deployment Templates
    participant K8s as Kubernetes

    User->>Values: Configure volumes
    Note over Values: Global extraVolumes<br/>or per-deployment volumes

    Values->>Templates: Pass configuration
    
    alt Global volumes only
        Templates->>Templates: Apply extraVolumes to all
    else Per-deployment volumes
        Templates->>Templates: Apply deployment-specific volumes
    else Both configured
        Templates->>Templates: Merge global + per-deployment
    end

    Templates->>K8s: Create deployment with volumes
    Note over K8s: volumeMounts in container<br/>volumes in pod spec
Loading

@waleedlatif1 waleedlatif1 merged commit 9a8b591 into staging Jan 22, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/helm branch January 22, 2026 19:35
waleedlatif1 added a commit that referenced this pull request Jan 22, 2026
…lution consolidation, helm updates (#2946)

* improvement(workflow-item): stabilize avatar layout and fix name truncation (#2939)

* improvement(workflow-item): stabilize avatar layout and fix name truncation

* fix(avatars): revert overflow bg to hardcoded color for contrast

* fix(executor): stop parallel execution when block errors (#2940)

* improvement(helm): add per-deployment extraVolumes support (#2942)

* fix(gmail): expose messageId field in read email block (#2943)

* fix(resolver): consolidate reference resolution  (#2941)

* fix(resolver): consolidate code to resolve references

* fix edge cases

* use already formatted error

* fix multi index

* fix backwards compat reachability

* handle backwards compatibility accurately

* use shared constant correctly

* feat(router): expose reasoning output in router v2 block (#2945)

* fix(copilot): always allow, credential masking (#2947)

* Fix always allow, credential validation

* Credential masking

* Autoload

* fix(executor): handle condition dead-end branches in loops (#2944)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants