fix(chat): remove special handling for non-streaming#2808
Merged
icecrasher321 merged 1 commit intostagingfrom Jan 14, 2026
Merged
fix(chat): remove special handling for non-streaming#2808icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryRemoved special handling code in the streaming response processor that was appending additional selected outputs (like model, tokens, toolCalls) to streaming messages. This code was causing duplicate output to be displayed in the chat interface. Key changes:
Impact:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Chat as Chat Component
participant Stream as processStreamingResponse
participant Store as Chat Store
User->>Chat: Send message
Chat->>Chat: handleSendMessage()
Chat->>Chat: handleRunWorkflow()
alt Streaming Response
Chat->>Stream: processStreamingResponse(stream, messageId)
loop Read stream chunks
Stream->>Stream: Parse SSE events
alt Content chunk
Stream->>Store: appendMessageContent(messageId, chunk)
else Final event (success=false)
Stream->>Store: appendMessageContent(messageId, error)
Stream->>Store: finalizeMessageStream(messageId)
else Final event (success=true)
Note over Stream: Removed: extracting additional outputs
Stream->>Store: finalizeMessageStream(messageId)
end
end
else Non-Streaming Response
Chat->>Chat: handleWorkflowResponse(result)
loop For each selected output
Chat->>Store: addMessage(output)
end
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove special handling in client chat for non streaming block. Was appending additional output.
Type of Change
Testing
Tested manually
Checklist