fix(preproc-errors): should not charge base execution cost in this case#2719
Merged
icecrasher321 merged 2 commits intostagingfrom Jan 7, 2026
Merged
fix(preproc-errors): should not charge base execution cost in this case#2719icecrasher321 merged 2 commits intostagingfrom
icecrasher321 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
|
@greptile |
Contributor
Greptile SummaryAdded logic to skip base execution charges for preprocessing errors. When a workflow fails during preprocessing (before actual execution begins), the Key changes:
This ensures users are not charged for executions that fail validation checks (workflow not found, rate limits, usage limits, billing errors, etc.) before any actual workflow execution occurs. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant PreprocessExecution
participant LoggingSession
participant Database
Client->>PreprocessExecution: Execute workflow
alt Validation Fails (e.g., workflow not found, rate limit, usage limit)
PreprocessExecution->>PreprocessExecution: logPreprocessingError()
PreprocessExecution->>LoggingSession: safeStart()
LoggingSession->>Database: Create execution log entry
PreprocessExecution->>LoggingSession: safeCompleteWithError({skipCost: true})
alt skipCost = true (NEW)
LoggingSession->>LoggingSession: Set all cost fields to 0
Note over LoggingSession: totalCost: 0<br/>baseExecutionCharge: 0<br/>modelCost: 0
else skipCost = false (existing behavior)
LoggingSession->>LoggingSession: Apply BASE_EXECUTION_CHARGE ($0.001)
end
LoggingSession->>Database: Update execution log with cost
LoggingSession-->>PreprocessExecution: Error logged
PreprocessExecution-->>Client: Return preprocessing error
else Validation Passes
PreprocessExecution-->>Client: Continue to workflow execution
Note over Client: Normal execution with standard cost tracking
end
|
waleedlatif1
pushed a commit
that referenced
this pull request
Jan 8, 2026
…se (#2719) * fix(preproc-errors): should not charge base execution cost in this case * remove comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip cost for preprocessing errors since there was no workflow execution.
Type of Change
Testing
Tested manually
Checklist