fix(condition): added success check on condition block processor, fixed terminal preventDefault copy bug#2691
Conversation
…ed terminal preventDefault copy bug
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR fixes two distinct bugs: Function Execution Error Handling: The Copy Keyboard Shortcut Fix: The global Ctrl/Cmd+C handler in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant CH as ConditionHandler
participant ET as executeTool
participant TR as transformResponse
participant API as /api/function/execute
CH->>ET: evaluateConditionExpression(ctx, expression)
ET->>TR: Call with function_execute config
TR->>API: POST /api/function/execute
alt Execution Success
API-->>TR: { success: true, output: {...} }
TR-->>ET: { success: true, output: {...} }
ET-->>CH: Boolean(result.output.result)
else Execution Failure (BEFORE fix)
API-->>TR: { success: false, error: "...", output: {...} }
Note over TR: BUG: Always returned success: true
TR-->>ET: { success: true, output: {...} }
ET-->>CH: Boolean(result.output.result)
Note over CH: Wrong path taken!
else Execution Failure (AFTER fix)
API-->>TR: { success: false, error: "...", output: {...} }
Note over TR: Now checks result.success
TR-->>ET: { success: false, error: "...", output: {...} }
ET-->>CH: Throws error
Note over CH: Correct error handling
end
|
…ed terminal preventDefault copy bug (#2691)
Summary
Type of Change
Testing
Tested manually
Checklist