fix(mcp): exclude serverUrl from mcp tool call params#2654
Merged
icecrasher321 merged 1 commit intostagingfrom Dec 31, 2025
Merged
fix(mcp): exclude serverUrl from mcp tool call params#2654icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR fixes a bug where The fix adds Changes:
Context:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as MCP Tools List UI
participant Executor as executeTool()
participant McpHandler as executeMcpTool()
participant Filter as MCP_SYSTEM_PARAMETERS
participant MCPServer as MCP Server
UI->>Executor: Call with params {serverId, serverUrl, toolName, serverName, ...args}
Executor->>McpHandler: Forward MCP tool request
Note over McpHandler,Filter: Extract tool arguments
McpHandler->>Filter: Filter out system parameters
Filter-->>McpHandler: Returns only tool-specific args
Note over Filter: BEFORE FIX: serverUrl was included ❌<br/>AFTER FIX: serverUrl is filtered out ✅
McpHandler->>MCPServer: Execute tool with filtered args
MCPServer-->>McpHandler: Return execution result
McpHandler-->>Executor: Return ToolResponse
Executor-->>UI: Display result
|
Sg312
pushed a commit
that referenced
this pull request
Jan 3, 2026
waleedlatif1
pushed a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Need to exclude serverUrl from mcp tool call params.
Type of Change
Testing
Tested manually with @aadamgough
Checklist