Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryReplaced hardcoded hex color values with CSS variables in the Key changes:
This ensures markdown content is visible in both light and dark modes by using the theme system's CSS variables that adjust based on the active theme. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant NoteBlock
participant NoteMarkdown
participant ReactMarkdown
participant ThemeSystem
User->>NoteBlock: View note in light mode
NoteBlock->>NoteMarkdown: Render content with markdown
NoteMarkdown->>ReactMarkdown: Pass custom components with CSS classes
ReactMarkdown->>ThemeSystem: Apply text-[var(--text-primary)]
ThemeSystem-->>ReactMarkdown: Resolve to #2d2d2d (light mode)
ReactMarkdown->>ThemeSystem: Apply bg-[var(--surface-5)]
ThemeSystem-->>ReactMarkdown: Resolve to #f3f3f3 (light mode)
ReactMarkdown-->>NoteMarkdown: Render with theme-aware colors
NoteMarkdown-->>NoteBlock: Display markdown
NoteBlock-->>User: Show visible text in light mode
|
Sg312
pushed a commit
that referenced
this pull request
Jan 3, 2026
waleedlatif1
pushed a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed light mode on note block. Previously, some markdown was hard to see or invisible.
Type of Change
Testing
Solo.
Checklist