improvement(files): cleanup pass — remove unnecessary useCallbacks, consolidate emcn icon imports

- Remove useCallback from 5 drag-event handlers in DataRow (passed to native <tr> elements, no observer)
- Remove stable useCallback fns from 3 useMemo deps arrays in files.tsx (editingId/editValue remain)
- Merge all @/components/emcn/icons subpath imports into barrel (files.tsx, action-bar, file-row-context-menu)

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/components/resource/resource.tsx

@@ -534,40 +534,25 @@ const DataRow = memo(function DataRow({
     [selectable, row.id]
   )
 
-  const handleDragStart = useCallback(
-    (e: DragEvent<HTMLTableRowElement>) => {
-      rowDragDrop?.onDragStart?.(e, row.id)
-    },
-    [rowDragDrop, row.id]
-  )
+  const handleDragStart = (e: DragEvent<HTMLTableRowElement>) => {
+    rowDragDrop?.onDragStart?.(e, row.id)
+  }
 
-  const handleDragOver = useCallback(
-    (e: DragEvent<HTMLTableRowElement>) => {
-      rowDragDrop?.onDragOver?.(e, row.id)
-    },
-    [rowDragDrop, row.id]
-  )
+  const handleDragOver = (e: DragEvent<HTMLTableRowElement>) => {
+    rowDragDrop?.onDragOver?.(e, row.id)
+  }
 
-  const handleDragLeave = useCallback(
-    (e: DragEvent<HTMLTableRowElement>) => {
-      rowDragDrop?.onDragLeave?.(e, row.id)
-    },
-    [rowDragDrop, row.id]
-  )
+  const handleDragLeave = (e: DragEvent<HTMLTableRowElement>) => {
+    rowDragDrop?.onDragLeave?.(e, row.id)
+  }
 
-  const handleDrop = useCallback(
-    (e: DragEvent<HTMLTableRowElement>) => {
-      rowDragDrop?.onDrop?.(e, row.id)
-    },
-    [rowDragDrop, row.id]
-  )
+  const handleDrop = (e: DragEvent<HTMLTableRowElement>) => {
+    rowDragDrop?.onDrop?.(e, row.id)
+  }
 
-  const handleDragEnd = useCallback(
-    (e: DragEvent<HTMLTableRowElement>) => {
-      rowDragDrop?.onDragEnd?.(e, row.id)
-    },
-    [rowDragDrop, row.id]
-  )
+  const handleDragEnd = (e: DragEvent<HTMLTableRowElement>) => {
+    rowDragDrop?.onDragEnd?.(e, row.id)
+  }
 
   return (
     <tr

apps/sim/app/workspace/[workspaceId]/files/components/action-bar/action-bar.tsx

@@ -9,10 +9,10 @@ import {
   DropdownMenuItem,
   DropdownMenuSeparator,
   DropdownMenuTrigger,
+  Folder,
   Tooltip,
   Trash2,
 } from '@/components/emcn'
-import { Folder } from '@/components/emcn/icons'
 import { cn } from '@/lib/core/utils/cn'
 import type { MoveOptionNode } from '@/app/workspace/[workspaceId]/files/move-options'
 import { renderMoveOption } from '@/app/workspace/[workspaceId]/files/move-options'

apps/sim/app/workspace/[workspaceId]/files/components/file-row-context-menu/file-row-context-menu.tsx

@@ -12,10 +12,11 @@ import {
   DropdownMenuSubTrigger,
   DropdownMenuTrigger,
   Eye,
+  Folder,
+  FolderInput,
   Pencil,
   Trash2,
 } from '@/components/emcn'
-import { Folder, FolderInput } from '@/components/emcn/icons'
 import type { MoveOptionNode } from '@/app/workspace/[workspaceId]/files/move-options'
 import { renderMoveOption } from '@/app/workspace/[workspaceId]/files/move-options'
 

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -11,6 +11,9 @@ import {
   type ComboboxOption,
   Download,
   Eye,
+  File as FilesIcon,
+  Folder,
+  FolderPlus,
   Loader,
   Modal,
   ModalBody,
@@ -23,7 +26,6 @@ import {
   toast,
   Upload,
 } from '@/components/emcn'
-import { File as FilesIcon, Folder, FolderPlus } from '@/components/emcn/icons'
 import { getDocumentIcon } from '@/components/icons/document-icons'
 import { triggerFileDownload } from '@/lib/uploads/client/download'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
@@ -474,15 +476,7 @@ export function Files() {
         },
       }
     })
-  }, [
-    baseRows,
-    listRename.editingId,
-    listRename.editValue,
-    listRename.setEditValue,
-    listRename.submitRename,
-    listRename.cancelRename,
-    filteredFiles,
-  ])
+  }, [baseRows, listRename.editingId, listRename.editValue, filteredFiles])
 
   const visibleRowIds = useMemo(() => rows.map((row) => row.id), [rows])
 
@@ -1015,9 +1009,6 @@ export function Files() {
       handleBackAttempt,
       headerRename.editingId,
       headerRename.editValue,
-      headerRename.setEditValue,
-      headerRename.submitRename,
-      headerRename.cancelRename,
       handleStartHeaderRename,
       handleDownloadSelected,
       handleDeleteSelected,
@@ -1541,9 +1532,6 @@ export function Files() {
     canEdit,
     breadcrumbRename.editingId,
     breadcrumbRename.editValue,
-    breadcrumbRename.setEditValue,
-    breadcrumbRename.submitRename,
-    breadcrumbRename.cancelRename,
   ])
 
   const memberOptions: ComboboxOption[] = useMemo(