fix(routes): replace instanceof Error with toError() across new workspace file routes

Author: waleedlatif1

apps/sim/app/api/workspaces/[id]/files/bulk-archive/route.ts

@@ -1,5 +1,6 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { createLogger } from '@sim/logger'
+import { toError } from '@sim/utils/errors'
 import { type NextRequest, NextResponse } from 'next/server'
 import { bulkArchiveWorkspaceFileItemsContract } from '@/lib/api/contracts/workspace-file-folders'
 import { parseRequest } from '@/lib/api/server'
@@ -66,7 +67,7 @@ export const POST = withRouteHandler(
       return NextResponse.json(
         {
           success: false,
-          error: error instanceof Error ? error.message : 'Failed to archive items',
+          error: toError(error).message,
         },
         { status: 400 }
       )

apps/sim/app/api/workspaces/[id]/files/download/route.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { toError } from '@sim/utils/errors'
 import JSZip from 'jszip'
 import { type NextRequest, NextResponse } from 'next/server'
 import { downloadWorkspaceFileItemsContract } from '@/lib/api/contracts/workspace-file-folders'
@@ -144,10 +145,7 @@ export const GET = withRouteHandler(
       })
     } catch (error) {
       logger.error('Failed to download workspace file selection:', error)
-      return NextResponse.json(
-        { error: error instanceof Error ? error.message : 'Failed to download selected files' },
-        { status: 500 }
-      )
+      return NextResponse.json({ error: toError(error).message }, { status: 500 })
     }
   }
 )

apps/sim/app/api/workspaces/[id]/files/folders/[folderId]/route.ts

@@ -1,6 +1,6 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { createLogger } from '@sim/logger'
-import { getPostgresErrorCode } from '@sim/utils/errors'
+import { getPostgresErrorCode, toError } from '@sim/utils/errors'
 import { type NextRequest, NextResponse } from 'next/server'
 import {
   deleteWorkspaceFileFolderContract,
@@ -80,7 +80,7 @@ export const PATCH = withRouteHandler(
       return NextResponse.json(
         {
           success: false,
-          error: error instanceof Error ? error.message : 'Failed to update folder',
+          error: toError(error).message,
         },
         { status: 400 }
       )
@@ -127,7 +127,7 @@ export const DELETE = withRouteHandler(
       return NextResponse.json(
         {
           success: false,
-          error: error instanceof Error ? error.message : 'Failed to delete folder',
+          error: toError(error).message,
         },
         { status: 400 }
       )

apps/sim/app/api/workspaces/[id]/files/folders/route.ts

@@ -1,5 +1,6 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { createLogger } from '@sim/logger'
+import { toError } from '@sim/utils/errors'
 import { type NextRequest, NextResponse } from 'next/server'
 import {
   createWorkspaceFileFolderContract,
@@ -88,9 +89,8 @@ export const POST = withRouteHandler(
       return NextResponse.json({ success: true, folder })
     } catch (error) {
       logger.error('Failed to create workspace file folder:', error)
-      const message = error instanceof Error ? error.message : 'Failed to create folder'
       return NextResponse.json(
-        { success: false, error: message },
+        { success: false, error: toError(error).message },
         { status: error instanceof WorkspaceFileFolderConflictError ? 409 : 400 }
       )
     }