Skip to content

fix snapshot API response #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boddumanohar wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix snapshot API response #1113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions simplyblock_web/api/v2/_dtos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from ipaddress import IPv4Address
from typing import List, Literal, Tuple, Optional, cast
from uuid import UUID
Expand Down Expand Up @@ -273,7 +273,7 @@ def from_model(
size=model.size,
used_size=model.used_size,
migrating=is_migrating,
created_at=datetime.fromtimestamp(model.created_at),
created_at=datetime.fromtimestamp(model.created_at, tz=timezone.utc),
lvol=str(
request.url_for(
"clusters:pools:volumes:detail",
Expand All @@ -282,7 +282,7 @@ def from_model(
volume_id=model.lvol.get_id(),
)
)
if model.lvol is not None and (volume_id == model.lvol.get_id())
if model.lvol is not None and (volume_id is None or volume_id == model.lvol.get_id())
else None,
)

Expand Down
Loading