Allow sending of metadata with sendFile#419
Allow sending of metadata with sendFile#419samsont wants to merge 1 commit intosimplewebrtc:masterfrom
Conversation
If you send a file: added the ability to send metadata about the file. The functionality was already in place, just added a spot for the additional data.
|
I like this. @latentflip? |
|
i would rather call |
|
I agree with the comment on metadata. The challenge is that on the receiving side, there already is a variable called metadata. (https://github.com/otalk/filetransfer/blob/master/filetransfer.js) . There is a A simpler thing to do might be that instead of using what I wrote: If I made that change, might that be ok? Thanks! |
|
maybe |
|
I think its safe to call this metadata, this should not conflict with the use of that name in filetransfer? |
|
Any plans on merging this change? It has been two years, so I am curious. I want this change. |
When you send a file: added the ability to send metadata with the file. The functionality was already in place, just added a spot for the additional data.