Fix goal line browser bug #5755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari is strict and returns Invalid Date for non-ISO strings such as 2024-12 or Dec 2024, so getMonth() becomes NaN, propagating through the improvement ratio and goal calculation (the text bubble then renders “Goal: … NaN%”). Because monthIndexFromDateKey feeds relativeImprovementRatio (used in calculateGoal → withGoalLineConfig), an invalid date in Safari makes the goal value NaN. Consider normalizing the date key before parsing (e.g., append -01 to make YYYY-MM-01 or parse with a month map) so getMonth() is stable across browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: 17479
Because
There is a bug preventing the % value for the goal line to show as NaN outside of chrome (Safari - and possibly others)
This addresses
This fixes that issue, and is working on Chome, Safari, Opera. Unable to test on Firefox.
Safari is strict and returns Invalid Date for non-ISO strings such as 2024-12 or Dec 2024, so getMonth() becomes NaN, (the text bubble then renders “Goal: … NaN%”).
Normalizing the date key before parsing so getMonth() is stable across browsers.
Test instructions
goal-lines-NaN-safari-bug-fixgoals-linesflipper flag and enable allreports.jsline 690 and change the line fromIN: []to ->IN: ["organization", "state", "district", "block", "facility"],