Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sqlite_utils/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -3088,12 +3088,12 @@ def preview(v):
db.conn.create_function("preview_transform", 1, preview)
sql = """
select
[{column}] as value,
preview_transform([{column}]) as preview
from [{table}]{where} limit 10
{column} as value,
preview_transform({column}) as preview
from {table}{where} limit 10
""".format(
column=columns[0],
table=table,
column=quote_identifier(columns[0]),
table=quote_identifier(table),
where=" where {}".format(where) if where is not None else "",
)
for row in db.conn.execute(sql, where_args).fetchall():
Expand Down
19 changes: 19 additions & 0 deletions tests/test_cli_convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,25 @@ def test_convert_dryrun(test_db_and_path):
assert result.output.strip().split("\n")[-1] == "Would affect 1 row"


def test_convert_dryrun_identifier_with_closing_bracket(tmpdir):
db_path = str(pathlib.Path(tmpdir) / "data.db")
db = sqlite_utils.Database(db_path)
db["example]table"].insert({"value]x": "alpha"})
result = CliRunner().invoke(
cli.cli,
[
"convert",
db_path,
"example]table",
"value]x",
"value.upper()",
"--dry-run",
],
)
assert result.exit_code == 0, result.output
assert result.output.strip() == "alpha\n --- becomes:\nALPHA\n\nWould affect 1 row"


def test_convert_multi_dryrun(test_db_and_path):
db_path = test_db_and_path[1]
result = CliRunner().invoke(
Expand Down
Loading