Render literal HTML in message text as text, not live markup - #107
Open
dchaudhari7177 wants to merge 1 commit into
Open
Render literal HTML in message text as text, not live markup#107dchaudhari7177 wants to merge 1 commit into
dchaudhari7177 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
render_markdown_text()passed message text straight throughmarkdown.markdown(), which by design lets raw HTML through. So literal HTML in a prompt became live markup — an unclosed<style>/<head>in an instruction silently swallowed the rest of the rendered transcript (content present in the file, never displayed), and<script>would execute on open.Following the issue's suggested fix,
render_markdown_textnow builds amarkdown.Markdowninstance and deregisters thehtml_blockpreprocessor andhtmlinline pattern, so tags render as escaped, visible text. Deregistering (rather than escaping the input first) keeps fenced code blocks intact —fenced_codestashes their content in a preprocessor that runs beforehtml_block, so nothing gets double-escaped.Verified:
<head>/<style>now render as<head>/<style>(no live tags); a```htmlfenced block is preserved as escaped code; bold/code/lists/tables still render. Addedtest_render_markdown_text_escapes_literal_htmlandtest_render_markdown_text_keeps_fenced_html; the full test suite (124 passed, existing snapshots unchanged) stays green.