Conversation
tskisner
reviewed
Dec 19, 2025
Member
tskisner
left a comment
tskisner
left a comment
There was a problem hiding this comment.
Just wanted to give some feedback, but I know you are going to split this operator up.
keskitalo
force-pushed
the
toast_intensity_templates
branch
from
a07bd0c to
975dd58
Compare
keskitalo
force-pushed
the
toast_intensity_templates
branch
from
df06f99 to
a4efe5e
Compare
tskisner
requested changes
Feb 20, 2026
Member
tskisner
left a comment
tskisner
left a comment
There was a problem hiding this comment.
There are a few minor things: removing manual timers and one bug in the non-MPI case. Also I'm interested in discussion / feedback about the trait organization comments.
tskisner
approved these changes
Feb 20, 2026
Member
tskisner
left a comment
tskisner
left a comment
There was a problem hiding this comment.
Thanks for the fixes, I'm surprised that the tests are passing even without upstream changes available in a tag. I guess the intensity template interface has not been broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the facilities to precompute intensity-based templates in TOAST FilterBin and TOAST MapMaker.
Should not be merged before hpc4cmb/toast#916