Added ability to query more temperatures in agent acq#730
Added ability to query more temperatures in agent acq#730
Conversation
BrianJKoopman
left a comment
There was a problem hiding this comment.
This is great, we were just talking about adding these temperatures to the readout today.
The tests are hanging up because the test for the acq process doesn't know about the queries/responses to these addresses. Can you add a representative query/response to them here:
socs/tests/integration/test_pfeiffer_tc400_agent_integration.py
Lines 170 to 173 in 99854a7
(The tests will continue to hang in the CI until that's fixed. Working on a fix for that upstream in ocs so it'll be more obvious in future PRs.)
| "Error_Code": "Err001", | ||
| "Error_Code": "1", |
There was a problem hiding this comment.
Is this really what's coming back? It looks like a string is being stored in InfluxDB. I see "000000" for turbos running on satp1, so maybe let's format this as "000001"?
There was a problem hiding this comment.
You're right. What happened I think is that I tested casting the error code to make it readable on grafana and it worked so I wrongly assumed it was a simple int. I tried to separate that error code testing from this PR so we could tackle it differently but I accidentally forgot to revert this change, my b!
Added extra turbo Temperature queries in the agent acq. Added a new function in drivers.py that queries all available turbo temperatures.
Description
Added
get_turbo_temperatures()in drivers.py that queries all available turbo temperatures.Changed the acq in agent.py to use
get_turbo_temperatures()instead ofget_turbo_motor_temperature(),Added powerstage, electronics, pumpbottom, and bearing temperatures to the data in acq.
Motivation and Context
There are multiple turbo temperatures and previously only the motor temperature was being queried.
Added functionality to allow us to see all of the available temperatures on grafana in case one of the previously unqueried temps were to cause an error.
How Has This Been Tested?
I tested this on daq-dev and was able to show that the agent ran acq just fine.
All of the above temperatures were able to be seen on grafana.
Types of changes
Checklist: