Fixed LS240 connection drop crashing acq process#430
Merged
BrianJKoopman merged 8 commits intomainfrom Mar 9, 2026
Merged
Conversation
We don't want to handle interrupts with this too, which BaseException includes.
BrianJKoopman
approved these changes
Mar 9, 2026
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good, and is definitely an improvement over having no error handling. I made one small change to handle the slightly less broad Exception instead of BaseException, but other than that I'm happy with this for now.
Sorry this sat forever -- it's not how I initially envisioned handling this, and I might change how it works again soon (generically for all serial devices), but I wanted to get this merged, finally.
This was referenced Mar 9, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed agent code to handle connection drops without crashing the acq process.
Description
When a connection drop occurs, the process will stop the current loop and attempt to run
init_lakeshoreto re-initialize the data fields. The re-initialization will try once every second until reconnection and then the loop continues.Motivation and Context
Addresses connection drop issues seen across all groups using LS240's.
Possibly fixes #418 and any other old issues?
How Has This Been Tested?
Tested by pulling USB connection and re-connecting. Testing environment is a nuc machine at Yale running Ubuntu 18.04 (required for Anyplace coolgear drivers to work). Works on LS240's connected either directly to nuc or to the Anyplace device.
Types of changes
Checklist: