-
Notifications
You must be signed in to change notification settings - Fork 2
Er/bundler updates 260112 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Store atomic map info (wafer-band, split) in bundle db
Swith to pandas DataFrame to allow mixed dtypes
Match behaviour to the load_from_db case Refactor coordinator
|
Switched back to draft as I want to simplify the Coadder too, using the new improvements to the Coordinator. |
|
After testing with an ISO like config this seems to be working for bundling and sign-flip. Have not tested with filtering looking through |
|
Happy to review and test this branch on v4 sim filtering and coadding. |
Significant changes and updates to the bundling code. Main changes:
atomic_dbis no longer a valid argument. Instead, a new tableatomichas been added to the bundle db; this contains columnsobs_id wafer freq_channel split_label median_weight_qu basenamefor every atomic map that exists and passes selection criteria (query_restrict,atomic_list). Maps for coaddition are taken from this table instead of making a new query.atomic_listis now applied to the bundle db, so only wafer/obs in the list will be included in the db. This will change median values for inter-obs splits whenatomic_listis used.atomic_listcan still be passed as an argument to the Coadder to further restrict what is coadded if desired.Coordinatorclass by usingpandas.DataFrameinstead of raw numpy arrays. Bundles are still assigned randomly per-obs with number obs/bundle forced to be equal; however the bundle assignment will be different for the same seed relative to old code.map_dirhas been changed from an optional to required argument in all functions.