Skip to content

fix(ci): check_dependencies - remove check_auth run #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminLangenakenSF merged 3 commits into from
Mar 27, 2026
Merged

fix(ci): check_dependencies - remove check_auth run #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa9f4ce
Pass SF_API_CLIENT_ID and SF_API_SECRET into check-dependencies job
BenjaminLangenakenSF Mar 27, 2026
83ff0c8
refactor(ci): remove extra CLI version call in check-dependencies
BenjaminLangenakenSF Mar 27, 2026
ce818ba
refactor(ci): inline silverfin-cli install into check-dependencies step
BenjaminLangenakenSF Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/check_dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
# Reusable workflow: call from a consumer repo with pull_request (labeled) and/or workflow_dispatch.
#
# Does not run check_auth: that job updates CONFIG_JSON via gh secret set, which notifies
# repo/org admins by email. The CLI check-dependencies command only scans local Liquid Test
# YAML files and does not need API credentials.
# repo/org admins by email. check-dependencies only scans local Liquid Test YAML files.
name: Check dependencies
run-name: Check dependencies for changed reconciliation templates
on:
Expand Down Expand Up @@ -140,19 +139,14 @@ jobs:
});
}

- name: Setup Node and Silverfin CLI
if: steps.handles.outputs.handles_json != '[]'
run: |
npm install https://github.com/silverfin/silverfin-cli.git
node ./node_modules/silverfin-cli/bin/cli.js -V

# Run check-dependencies for each handle and collect results
- name: Run check-dependencies per handle
id: run-check
if: steps.handles.outputs.handles_json != '[]'
env:
HANDLES_JSON: ${{ steps.handles.outputs.handles_json }}
run: |
npm install https://github.com/silverfin/silverfin-cli.git
job_failed=0
: > check_results.txt
while IFS= read -r handle; do
Expand Down
Loading