-
Notifications
You must be signed in to change notification settings - Fork 0
Add reusable check_dependencies workflow (workflow_call) #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BenjaminLangenakenSF
merged 6 commits into
main
from
add-check-dependencies-reusable-workflow
Mar 27, 2026
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d2d5dd6
Add reusable check_dependencies workflow for consumer repos
BenjaminLangenakenSF 28d1164
Drop check_auth from check_dependencies to avoid secret-update emails
BenjaminLangenakenSF 553f7fb
Define workflow_call input pull_request_number and resolve PR in scripts
BenjaminLangenakenSF 1242db0
Pass PR file list via CHANGED_FILES env in handle-resolution step
BenjaminLangenakenSF b96d36e
Checkout PR head SHA for check-dependencies workspace
BenjaminLangenakenSF 08f922b
Iterate handles with read loop to avoid word-splitting on jq output
BenjaminLangenakenSF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,221 @@ | ||
| # Runs `silverfin check-dependencies -h <handle>` for each reconciliation template | ||
| # changed in the PR. Triggered only when the `code-review` label is added. | ||
| # Reusable workflow: call from a consumer repo with pull_request (labeled) and/or workflow_dispatch. | ||
| # Runs check_auth first to refresh tokens (same pattern as run_tests). | ||
| name: Check dependencies | ||
| run-name: Check dependencies for changed reconciliation templates | ||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| check-auth: | ||
| # Refresh Silverfin API tokens (same as run_tests) | ||
| if: github.event.label.name == 'code-review' || github.event_name == 'workflow_dispatch' | ||
| uses: ./.github/workflows/check_auth.yml | ||
| secrets: inherit | ||
|
|
||
| check-dependencies: | ||
| # Run when the added label is "code-review" (pull_request) or when triggered manually (workflow_dispatch) | ||
| if: github.event.label.name == 'code-review' || github.event_name == 'workflow_dispatch' | ||
| needs: [check-auth] | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| env: | ||
| SF_API_CLIENT_ID: "${{ secrets.SF_API_CLIENT_ID }}" | ||
| SF_API_SECRET: "${{ secrets.SF_API_SECRET }}" | ||
| steps: | ||
| # Resolve PR base SHA (required for checkout; undefined for workflow_dispatch) | ||
| - name: Get PR details | ||
| id: pr-details | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const prNumber = context.payload.pull_request?.number || context.payload.inputs?.pull_request_number; | ||
| const { data: pr } = await github.rest.pulls.get({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: prNumber | ||
| }); | ||
| core.setOutput("base_sha", pr.base.sha); | ||
|
|
||
| # Check out base branch (used for config.json / handle resolution; file list from API) | ||
| - name: Checkout base branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ steps.pr-details.outputs.base_sha }} | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Get list of files changed in the PR via API (no PR checkout) | ||
| - name: Get PR changed files | ||
| id: pr-files | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const prNumber = context.payload.pull_request?.number || context.payload.inputs?.pull_request_number; | ||
| const files = await github.paginate(github.rest.pulls.listFiles, { | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: prNumber | ||
| }); | ||
| const paths = files.map(f => f.filename).join("\n"); | ||
| core.setOutput("paths", paths); | ||
|
|
||
| # Derive reconciliation handles from changed paths (same pattern as run_tests "Filter templates changed") | ||
| - name: Get reconciliation handles to check | ||
| id: handles | ||
| run: | | ||
| changed_files="${{ steps.pr-files.outputs.paths }}" | ||
| pattern="reconciliation_texts/([^/]+)/" | ||
| if [ -n "$changed_files" ]; then | ||
| filtered_names=($(printf "%s\n" "$changed_files" | grep -oE "$pattern" | sed "s|reconciliation_texts/||;s|/||" | sort -u)) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| else | ||
| filtered_names=() | ||
| fi | ||
| # Resolve handle from config.json if present (explicit mapping), else use directory name | ||
| handles=() | ||
| for dir in "${filtered_names[@]}"; do | ||
| config_path="reconciliation_texts/${dir}/config.json" | ||
| if [ -f "$config_path" ]; then | ||
| h=$(jq -r ".handle // .name // empty" "$config_path" 2>/dev/null || true) | ||
| [ -z "$h" ] && h="$dir" | ||
| else | ||
| h="$dir" | ||
| fi | ||
| handles+=("$h") | ||
| done | ||
| # Dedupe and output | ||
| if [ ${#handles[@]} -eq 0 ]; then | ||
| echo "handles_json=[]" >> $GITHUB_OUTPUT | ||
| echo "No reconciliation templates changed." | ||
| else | ||
| echo "handles_json=$(printf "%s\n" "${handles[@]}" | sort -u | jq -R -s -c "split(\"\n\") | map(select(length > 0))")" >> $GITHUB_OUTPUT | ||
| echo "Handles to check:" | ||
| printf "%s\n" "${handles[@]}" | sort -u | ||
| fi | ||
|
|
||
| - name: Post comment when no reconciliation templates changed | ||
| if: steps.handles.outputs.handles_json == '[]' | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const marker = "<!-- silverfin-check-dependencies -->"; | ||
| const body = [ | ||
| "## Silverfin check-dependencies", | ||
| "", | ||
| "No reconciliation templates were changed in this PR. Nothing to run.", | ||
| "", | ||
| marker | ||
| ].join("\n"); | ||
| const { owner, repo } = context.repo; | ||
| const prNumber = context.payload.pull_request?.number || context.payload.inputs?.pull_request_number; | ||
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner, repo, issue_number: prNumber | ||
| }); | ||
| const existing = comments.find(c => | ||
| c.user.type === "Bot" && c.body && c.body.includes(marker) | ||
| ); | ||
| if (existing) { | ||
| await github.rest.issues.updateComment({ | ||
| owner, repo, comment_id: existing.id, body | ||
| }); | ||
| } else { | ||
| await github.rest.issues.createComment({ | ||
| owner, repo, issue_number: prNumber, body | ||
| }); | ||
| } | ||
|
|
||
| - name: Setup Node and Silverfin CLI | ||
| if: steps.handles.outputs.handles_json != '[]' | ||
| run: | | ||
| npm install https://github.com/silverfin/silverfin-cli.git | ||
| node ./node_modules/silverfin-cli/bin/cli.js -V | ||
|
|
||
| - name: Load Silverfin config | ||
| if: steps.handles.outputs.handles_json != '[]' | ||
| run: | | ||
| mkdir -p $HOME/.silverfin/ | ||
| echo '${{ secrets.CONFIG_JSON }}' > $HOME/.silverfin/config.json | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Run check-dependencies for each handle and collect results | ||
| - name: Run check-dependencies per handle | ||
| id: run-check | ||
| if: steps.handles.outputs.handles_json != '[]' | ||
| env: | ||
| HANDLES_JSON: ${{ steps.handles.outputs.handles_json }} | ||
| run: | | ||
| job_failed=0 | ||
| : > check_results.txt | ||
| for handle in $(echo "$HANDLES_JSON" | jq -r ".[]"); do | ||
| echo "## Handle: \`${handle}\`" >> check_results.txt | ||
| echo "" >> check_results.txt | ||
| echo "Command: \`silverfin check-dependencies -h ${handle}\`" >> check_results.txt | ||
| echo "" >> check_results.txt | ||
| set +e | ||
| output=$(node ./node_modules/silverfin-cli/bin/cli.js check-dependencies -h "$handle" 2>&1) | ||
| exit_code=$? | ||
| set -e | ||
| echo '```' >> check_results.txt | ||
| echo "$output" >> check_results.txt | ||
| echo '```' >> check_results.txt | ||
| echo "" >> check_results.txt | ||
| if [[ $exit_code -ne 0 ]]; then | ||
| echo "**Status: Failed (exit code ${exit_code})**" >> check_results.txt | ||
| job_failed=1 | ||
| else | ||
| echo "**Status: OK**" >> check_results.txt | ||
| fi | ||
| echo "" >> check_results.txt | ||
| done | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| echo "results<<CHECK_EOF" >> $GITHUB_OUTPUT | ||
| cat check_results.txt >> $GITHUB_OUTPUT | ||
| echo "CHECK_EOF" >> $GITHUB_OUTPUT | ||
| echo "job_failed=$job_failed" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Post PR comment with results | ||
| if: steps.handles.outputs.handles_json != '[]' && always() && steps.run-check.outcome != 'skipped' | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const fs = require('fs'); | ||
| const marker = "<!-- silverfin-check-dependencies -->"; | ||
| const resultsContent = fs.existsSync('check_results.txt') | ||
| ? fs.readFileSync('check_results.txt', 'utf8') | ||
| : ''; | ||
| const body = [ | ||
| "## Silverfin check-dependencies", | ||
| "", | ||
| "Ran for reconciliation templates changed in this PR (triggered by `code-review` label).", | ||
| "", | ||
| resultsContent, | ||
| marker | ||
| ].join("\n"); | ||
|
|
||
| const prNumber = context.payload.pull_request?.number || context.payload.inputs?.pull_request_number; | ||
| const owner = context.repo.owner; | ||
| const repo = context.repo.repo; | ||
|
|
||
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner, repo, issue_number: prNumber | ||
| }); | ||
| const existing = comments.find(c => | ||
| c.user.type === "Bot" && c.body && c.body.includes(marker) | ||
| ); | ||
|
|
||
| if (existing) { | ||
| await github.rest.issues.updateComment({ | ||
| owner, repo, comment_id: existing.id, body | ||
| }); | ||
| console.log("Updated existing check-dependencies comment"); | ||
| } else { | ||
| await github.rest.issues.createComment({ | ||
| owner, repo, issue_number: prNumber, body | ||
| }); | ||
| console.log("Created new check-dependencies comment"); | ||
| } | ||
|
|
||
| - name: Fail job if any check-dependencies failed | ||
| if: steps.handles.outputs.handles_json != '[]' && steps.run-check.outputs.job_failed == '1' | ||
| run: | | ||
| echo "One or more silverfin check-dependencies runs failed. See PR comment for details." | ||
| exit 1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.