Skip to content

SF-3907 Fix draft being imported to wrong chapter - #4054

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/single-chapter-import-race-condition
Open

SF-3907 Fix draft being imported to wrong chapter#4054
Nateowami wants to merge 1 commit into
masterfrom
fix/single-chapter-import-race-condition

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Edit: I've opened SF-3907 to track this exact PR

SF-3905 is titled "Use the same method to add drafts in the editor as the wizard"

That might be the best approach, but it's non-trivial and introduces some serious complexity. This is a much more targeted fix.

This change is Reviewable

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (c756703) to head (a945141).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...late/editor/editor-draft/editor-draft.component.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4054      +/-   ##
==========================================
- Coverage   81.08%   81.08%   -0.01%     
==========================================
  Files         661      661              
  Lines       43061    43067       +6     
  Branches     7036     7038       +2     
==========================================
+ Hits        34917    34921       +4     
- Misses       6987     6988       +1     
- Partials     1157     1158       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. This looks like the right thing to do for now until the improvement from SF-3905 can be implemented

@RaymondLuong3 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@Nateowami Nateowami changed the title Fix draft being imported to wrong chapter SF-3907 Fix draft being imported to wrong chapter Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants