SF-3907 Fix note dialog being incorrectly closed

[Nateowami]

Supersedes #4045.

The bug was in the dialog service which in openMatDialog was not honoring disableClosed when passed in the options, because it would override the disableClose from the option with the positional argument.

I've eliminated the positional argument, since I think passing a boolean is very unclear. Meanwhile passing { disableClose: true } is very clear what it means. Additionally, having two ways to set the same property naturally leads to situations where they might conflict, which is what was happening here.

---

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (c756703) to head (aaf0521).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...aft-signup-form/draft-onboarding-form.component.ts	0.00%	1 Missing ⚠️
...ture/ClientApp/src/xforge-common/dialog.service.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4053   +/-   ##
=======================================
  Coverage   81.08%   81.09%           
=======================================
  Files         661      661           
  Lines       43061    43057    -4     
  Branches     7036     7033    -3     
=======================================
- Hits        34917    34916    -1     
+ Misses       6987     6980    -7     
- Partials     1157     1161    +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[RaymondLuong3]

@RaymondLuong3 reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Nateowami).

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/dialog.service.spec.ts line 38 at r1 (raw file):

  });

  it('confirm passes disableClose through to the underlying dialog', async () => {

It does not look like this async is necessary

Code quote:

nderlying dialog', async () => {

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/dialog.service.spec.ts line 44 at r1 (raw file):

  });

  it('message passes disableClose through to the underlying dialog', async () => {

Same as above.

Code quote:

 underlying dialog', async () => {

[Nateowami]

@Nateowami made 2 comments.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/dialog.service.spec.ts line 38 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

It does not look like this async is necessary

Done.

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/dialog.service.spec.ts line 44 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Same as above.

Done.

[RaymondLuong3]

@RaymondLuong3 reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).