SF-3895 Allow Serval admins to view settings, users, sync; add sync log

[Nateowami]

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 92.22222% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.14%. Comparing base (c756703) to head (82cff89).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...entApp/src/app/sync/sync-log/sync-log.component.ts	89.74%	0 Missing and 4 partials ⚠️
...aAccess/SFDataAccessServiceCollectionExtensions.cs	0.00%	3 Missing ⚠️
...e/ClientApp/src/app/settings/settings.component.ts	87.50%	0 Missing and 2 partials ⚠️
...Scripture/ClientApp/src/app/sync/sync.component.ts	60.00%	0 Missing and 2 partials ⚠️
...ture/ClientApp/src/app/core/permissions.service.ts	93.33%	1 Missing ⚠️
...pture/ClientApp/src/app/core/sf-project.service.ts	0.00%	1 Missing ⚠️
...ientApp/src/app/navigation/navigation.component.ts	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
+ Coverage   81.08%   81.14%   +0.05%     
==========================================
  Files         661      665       +4     
  Lines       43061    43200     +139     
  Branches     7036     7059      +23     
==========================================
+ Hits        34917    35053     +136     
+ Misses       6987     6980       -7     
- Partials     1157     1167      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ No screenshot differences — all stories are identical.

View the diff page at: https://pr-4038--sf-screenshot-diffs.netlify.app

[RaymondLuong3]

Nice work! I like the sync log. I think it may help to diagnose issues now that serval admins and system admins can quickly see the issue in the UI. I understand the decision to hide error details from the user since it would not be helpful most of the time to them. Just a few comments on this.

@RaymondLuong3 reviewed 47 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Nateowami).

---

src/SIL.XForge.Scripture/ClientApp/src/app/sync/sync-log/sync-log.component.spec.ts line 88 at r1 (raw file):

    env.clickButton(env.showMoreButton);
    env.wait();
    verify(mockedProjectService.onlineSyncMetrics(env.mockProjectId, 0, 15)).once();

Nit: Can this number of calculated rather than a magic number?

Code quote:

    env.wait();
    verify(mockedProjectService.onlineSyncMetrics(env.mockProjectId, 0, 15)).once();

---

src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1116 at r1 (raw file):

    /// <exception cref="FormatException">The page index or page size is invalid.</exception>
    private static void ValidatePagingParameters(int pageIndex, int pageSize)

C# methods should start with an uppercase.

Code quote:

    private static void ValidatePagingParameters(int pageIndex, int pageSize)

[Nateowami]

The main reason not to show the raw exception is that there are usually security implications to providing stack traces and raw error messages. But yes, it's also not very useful for users.

@Nateowami made 3 comments and resolved 1 discussion.
Reviewable status: 46 of 47 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/app/sync/sync-log/sync-log.component.spec.ts line 88 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Nit: Can this number of calculated rather than a magic number?

Done.

---

src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1116 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

C# methods should start with an uppercase.

It's uppercase. Or else I don't know what you're referring to.

[RaymondLuong3]

@RaymondLuong3 reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

---

src/SIL.XForge.Scripture/Services/SFProjectService.cs line 1116 at r1 (raw file):

Previously, Nateowami wrote…

It's uppercase. Or else I don't know what you're referring to.

Aha, my eyes are just deceiving me.