SF-3838 Add date and text filter on onboarding requests tab - #4024
SF-3838 Add date and text filter on onboarding requests tab#4024RaymondLuong3 wants to merge 4 commits into
Conversation
|
4e09f28 to
8f6ed2e
Compare
8f6ed2e to
19d6d07
Compare
Nateowami
left a comment
There was a problem hiding this comment.
I really don't think defaulting to a narrow date range on the onboarding request page is a good idea. The builds page and onboarding requests page are different in that:
- Onboarding requests are something that need to be dealt with (it's like an inbox, and limited to one per project)
- Builds are something you can review (it's like a log, and has no limit and can grow massive)
We probably do need to add some kind of filtering to avoid showing too many elements at once, but right now the default filtering already mostly addresses it.
It also creates some very non-intuitive views. If you click on "All" you might expect it might be filtered to recent issues and you could select to show more. But if you click on "mine" and it says there are none, you're probably not going to realize you have to select a wider time range to see all, and there's no option to show all.
@Nateowami made 1 comment.
Reviewable status: 0 of 10 files reviewed, all discussions resolved.
19d6d07 to
69308ce
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
You have a good point that setting a default date range does not make sense since there is not reason to filter the requests to a default range. I have removed the default filter so that onboarding requests are not filtered by date range until a range is selected.
@RaymondLuong3 made 1 comment.
Reviewable status: 0 of 14 files reviewed, all discussions resolved.
This PR adds the logic to allow filtering onboarding requests by date and strings in the request object. A new SearchRecordsComponent is now shared between the onboarding requests tab and the serval builds tab. Slight modifications were made to the template in the serval builds tab to align with the template in the Onboarding Requests tab.
Before

After

Before

After

This change is