Skip to content

SF-3801 Show chapters with content that adding a draft will overwrite#3903

Open
RaymondLuong3 wants to merge 1 commit into
masterfrom
feature/sf-3801-chapters-with-content
Open

SF-3801 Show chapters with content that adding a draft will overwrite#3903
RaymondLuong3 wants to merge 1 commit into
masterfrom
feature/sf-3801-chapters-with-content

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented May 22, 2026

This PR specifically lists the chapters that will get overwritten when applying a draft to a book. The chapters listed can be clicked and a new tab opens in the browser to allow the user view the content of the chapter.

Adding a single book to a project

Overwrite chapters single book

Adding multiple books to a project
Overwrite chapters multiple books


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (12f0d90) to head (7047530).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3903   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         630      630           
  Lines       40677    40679    +2     
  Branches     6578     6578           
=======================================
+ Hits        32909    32911    +2     
  Misses       6741     6741           
  Partials     1027     1027           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami
Copy link
Copy Markdown
Collaborator

@copilot Here is the original Jira issue for this change:

=== Start Jira issue ===
Title: Inform users which chapters will be overwritten on draft import
Description:
Currently the draft import dialog states how many chapters have content (see screenshot), but not which chapters have content.

Enumerate the chapters that have content
Make each chapter number a link (that opens in a new tab) to the chapter in SF, so it's possible to see what would be overwritten. Feedback from users has shown that sometimes the "content" is minimal and in a user's mind wouldn't be something they should be concerned about overwriting.
Change the intro text to something like “Click each chapter to view the content that will be overwritten”
=== End Jira issue ===

Please do a code review and a functionality review.

"importing": "Importing",
"next": "Next",
"no_books_ready_for_import": "No draft chapters are ready for import. Generate a draft and try again.",
"overwrite_book_description": "{{ bookName }} in {{ boldStart }}{{ projectShortName }} - {{ projectName }}{{ boldEnd }} has {{ numChapters }} chapters with existing text that will be overwritten.",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that we've lost a significant amount of clarity by going from specifically stating that there are chapters with existing text that will be overwritten to just saying "Overwrite ?" I know technically we're overwriting the entire book, but from a user's perspective they're doing an import, probably not expecting to overwrite anything. We should be extremely clear in why we are stopping to ask an additional question.

Copilot AI requested a review from Nateowami May 22, 2026 23:30
@Nateowami Nateowami force-pushed the feature/sf-3801-chapters-with-content branch from 0faa88e to 7047530 Compare May 22, 2026 23:50
@Nateowami
Copy link
Copy Markdown
Collaborator

Sorry about the Copilot commits. I've reverted them (I was trying to get it to review, not make changes).

I think you may want to re-read the issue description.

@Nateowami Nateowami temporarily deployed to screenshot_diff May 22, 2026 23:57 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants