Skip to content

SF-3743 Fix checking slowdown when a project has many questions#3754

Open
pmachapman wants to merge 3 commits intomasterfrom
fix/SF-3743
Open

SF-3743 Fix checking slowdown when a project has many questions#3754
pmachapman wants to merge 3 commits intomasterfrom
fix/SF-3743

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 23, 2026

This PR addresses speed issue in community checking by adding an index to the questions in IndexedDB, and by modifying change detection to push for the checking component and checking overview component.


Open with Devin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Mar 23, 2026
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.33%. Comparing base (a3e53c4) to head (fccb285).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...g/checking-overview/checking-overview.component.ts 88.23% 2 Missing ⚠️
...pp/src/app/checking/checking/checking.component.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3754      +/-   ##
==========================================
+ Coverage   81.32%   81.33%   +0.01%     
==========================================
  Files         620      620              
  Lines       39086    39115      +29     
  Branches     6375     6373       -2     
==========================================
+ Hits        31787    31815      +28     
- Misses       6316     6317       +1     
  Partials      983      983              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devin-ai-integration[bot]

This comment was marked as resolved.

@pmachapman pmachapman changed the title SF-3743 Fix checking slowdown when a project has many questions WIP: SF-3743 Fix checking slowdown when a project has many questions Mar 23, 2026
@pmachapman pmachapman marked this pull request as draft March 23, 2026 01:07
@Nateowami Nateowami added the e2e Run e2e tests for this pull request label Mar 23, 2026
@Nateowami
Copy link
Collaborator

My testing confirms a dramatic performance improvement. Thanks for tracking this down. IndexedDB indexes weren't even on my radar.

@pmachapman pmachapman marked this pull request as ready for review March 23, 2026 20:30
@pmachapman pmachapman changed the title WIP: SF-3743 Fix checking slowdown when a project has many questions SF-3743 Fix checking slowdown when a project has many questions Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants