SF-3743 Fix checking slowdown when a project has many questions#3754
Open
pmachapman wants to merge 3 commits intomasterfrom
Open
SF-3743 Fix checking slowdown when a project has many questions#3754pmachapman wants to merge 3 commits intomasterfrom
pmachapman wants to merge 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
+ Coverage 81.32% 81.33% +0.01%
==========================================
Files 620 620
Lines 39086 39115 +29
Branches 6375 6373 -2
==========================================
+ Hits 31787 31815 +28
- Misses 6316 6317 +1
Partials 983 983 ☔ View full report in Codecov by Sentry. |
Collaborator
|
My testing confirms a dramatic performance improvement. Thanks for tracking this down. IndexedDB indexes weren't even on my radar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses speed issue in community checking by adding an index to the questions in IndexedDB, and by modifying change detection to push for the checking component and checking overview component.
This change is